Subject: RE: [PATCH] Document MKDIR_WO_TRAILING_SLASH in Makefile

From: "Joachim Schmitz" <[email-masked]>
Date: Sat, 8 Sep 2012 17:23:00 +0200

> From: Joachim Schmitz [mailto:[email-masked]]
> Sent: Friday, September 07, 2012 8:28 PM
> To: 'Junio C Hamano'
> Cc: [email-masked]'
> Subject: RE: [PATCH] Document MKDIR_WO_TRAILING_SLASH in Makefile
> 
> 
> 
> > -----Original Message-----
> > From: Junio C Hamano [mailto:[email-masked]]
> > Sent: Friday, September 07, 2012 7:30 PM
> > To: Joachim Schmitz
> > Cc: [email-masked]
> > Subject: Re: [PATCH] Document MKDIR_WO_TRAILING_SLASH in Makefile
> >
> > "Joachim Schmitz" <[email-masked]> writes:
> >
> > > Signed-off-by: Joachim Schmitz <[email-masked]>
> > > ---
> > >  Makefile | 2 ++
> > >  1 file changed, 2 insertions(+)
> > >
> > > diff --git a/Makefile b/Makefile
> > > index ac49320..03e245a 100644
> > > --- a/Makefile
> > > +++ b/Makefile
> > > @@ -90,6 +90,8 @@ all::
> > >  #
> > >  # Define NO_MKDTEMP if you don't have mkdtemp in the C library.
> > >  #
> > > +# Define MKDIR_WO_TRAILING_SLASH if your mkdir() can't deal with trailing slash.
> > > +#
> > >  # Define NO_MKSTEMPS if you don't have mkstemps in the C library.
> > >  #
> > >  # Define NO_STRTOK_R if you don't have strtok_r in the C library.
> >
> > Not really.  "make MKDIR_WO_TRAILING_SLASH=YesPlease" won't do
> > anything.
> >
> > You would need at least something like this, no?
> >
> 
> Yes, that is better, thanks

There's something missing though, to make it fully usable, see below
> 
> >  Makefile | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git c/Makefile w/Makefile
> > index 66e8216..21b4816 100644
> > --- c/Makefile
> > +++ w/Makefile
> > @@ -90,6 +90,8 @@ all::
> >  #
> >  # Define NO_MKDTEMP if you don't have mkdtemp in the C library.
> >  #
> > +# Define MKDIR_WO_TRAILING_SLASH if your mkdir() can't deal with trailing slash.
> > +#
> >  # Define NO_MKSTEMPS if you don't have mkstemps in the C library.
> >  #
> >  # Define NO_STRTOK_R if you don't have strtok_r in the C library.
> > @@ -1639,6 +1641,9 @@ ifdef NO_MKDTEMP
> >  	COMPAT_CFLAGS += -DNO_MKDTEMP
> >  	COMPAT_OBJS += compat/mkdtemp.o
> >  endif
> > +ifdef MKDIR_WO_TRAILING_SLASH
> > +	COMPAT_CFLAGS += -DMKDIR_WO_TRAILING_SLASH

+	COMPAT_OBJS += compat/mkdir.o

> > +endif
> >  ifdef NO_MKSTEMPS
> >  	COMPAT_CFLAGS += -DNO_MKSTEMPS
> >  endif

Bye, Jojo