public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: "Joachim Schmitz" <jojo@schmitz-digital•de>
To: "'Junio C Hamano'" <gitster@pobox•com>
Cc: <git@vger•kernel.org>, "'Erik Faye-Lund'" <kusmabite@gmail•com>
Subject: RE: [PATCH v2] Support non-WIN32 system lacking poll() while keeping the WIN32 part intact
Date: Tue, 4 Sep 2012 13:49:16 +0200	[thread overview]
Message-ID: <002701cd8a93$50773e30$f165ba90$@schmitz-digital.de> (raw)
In-Reply-To: <7vboi0yswz.fsf@alter.siamese.dyndns.org>

> From: Junio C Hamano [mailto:gitster@pobox•com]
> Sent: Friday, August 24, 2012 9:47 PM
> To: Joachim Schmitz
> Cc: git@vger•kernel.org; 'Erik Faye-Lund'
> Subject: Re: [PATCH v2] Support non-WIN32 system lacking poll() while keeping the WIN32 part intact
> 
> "Joachim Schmitz" <jojo@schmitz-digital•de> writes:
> 
> > Different, but related question: would poll.[ch] be allowed to #include "git-compat-util.h"?
> 
> Seeing other existing generic wrappers directly under compat/,
> e.g. fopen.c, mkdtemp.c, doing so, I would say why not.
> 
> Windows folks (I see Erik is already CC'ed, which is good ;-),
> please work with Joachim to make sure such a move won't break your
> builds.  I believe that it should just be the matter of updating a
> couple of paths in the top-level Makefile.

Haven't heard anything from the Windows folks yet.

I'd prefer to move compat/win32/poll.[ch] into compat/poll.
Then adjust a few paths in Makefile and that would be the 1st patch

A 2nd patch would be my already proposed ones that make this usable for others (me in this case ;-)), namely wrapping 2 #inludes.

diff --git a/compat/poll/poll.c b/compat/poll/poll.c
index 403eaa7..49541f1 100644
--- a/compat/poll/poll.c
+++ b/compat/poll/poll.c
@@ -24,7 +24,9 @@
 # pragma GCC diagnostic ignored "-Wtype-limits"
 #endif

-#include <malloc.h>
+#if defined(WIN32)
+# include <malloc.h>
+#endif

 #include <sys/types.h>

@@ -48,7 +50,9 @@
 #else
 # include <sys/time.h>
 # include <sys/socket.h>
-# include <sys/select.h>
+# ifndef NO_SYS_SELECT_H
+#  include <sys/select.h>
+# endif
 # include <unistd.h>
 #endif

--
1.7.12

  reply	other threads:[~2012-09-04 11:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-24 13:05 [PATCH v2] Support non-WIN32 system lacking poll() while keeping the WIN32 part intact Joachim Schmitz
2012-08-24 16:07 ` Junio C Hamano
2012-08-24 18:58   ` Joachim Schmitz
2012-08-24 19:46     ` Junio C Hamano
2012-09-04 11:49       ` Joachim Schmitz [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-08-24  9:45 Joachim Schmitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='002701cd8a93$50773e30$f165ba90$@schmitz-digital.de' \
    --to=jojo@schmitz-digital$(echo .)de \
    --cc=git@vger$(echo .)kernel.org \
    --cc=gitster@pobox$(echo .)com \
    --cc=kusmabite@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox