Subject: RE: [BUG] Re: Git 2.35.0-rc0

From: <[email-masked]>
Date: Tue, 11 Jan 2022 15:39:02 -0500

On January 11, 2022 2:53 PM, Taylor Blau wrote:
> On Mon, Jan 10, 2022 at 10:51:39PM -0500, [email-masked]
> wrote:
> > I now have a different issue:
> >
> > make -C t/ all
> > make[1]: Entering directory '/home/git/git/t'
> > rm -f -r 'test-results'
> > /usr/coreutils/bin/bash: /usr/bin/perl: Argument list too long
> >
> > Is there anyway to move to xargs? I am not sure why /usr/bin/perl is
> > having issues with the build.
> 
> Tracing through t/Makefile, I am _pretty_ sure that this Perl invocation comes
> from the test-lint-shell-syntax recipe.
> 
> I wonder if something like this would do the trick?
> 
> --- 8< ---
> 
> diff --git a/t/Makefile b/t/Makefile
> index 46cd5fc527..d959119133 100644
> --- a/t/Makefile
> +++ b/t/Makefile
> @@ -90,7 +90,7 @@ test-lint-executable:
>  		echo >&2 "non-executable tests:" $$bad; exit 1; }
> 
>  test-lint-shell-syntax:
> -	@'$(PERL_PATH_SQ)' check-non-portable-shell.pl $(T) $(THELPERS)
> $(TPERF)
> +	@echo $(T) $(THELPERS) $(TPERF) | xargs '$(PERL_PATH_SQ)'
> +check-non-portable-shell.pl
> 
>  test-lint-filenames:
>  	@# We do *not* pass a glob to ls-files but use grep instead, to catch
> 
> --- >8 ---

I think we don't need this yet. My CI/CD system is a bit more robust and does not get stuck here.
--Randall