From: Ben Knoble <ben.knoble@gmail•com>
To: Junio C Hamano <gitster@pobox•com>
Cc: "D. Ben Knoble" <ben.knoble+github@gmail•com>,
git@vger•kernel.org, Patrick Steinhardt <ps@pks•im>,
Todd Zullinger <tmz@pobox•com>
Subject: Re: [PATCH] meson: make GIT_HTML_PATH configurable
Date: Tue, 4 Nov 2025 11:47:49 -0500 [thread overview]
Message-ID: <0423F0C4-D0AD-471D-9315-FB208A8171B4@gmail.com> (raw)
In-Reply-To: <xmqqms51rhbx.fsf@gitster.g>
> Le 4 nov. 2025 à 09:41, Junio C Hamano <gitster@pobox•com> a écrit :
>
> "D. Ben Knoble" <ben.knoble+github@gmail•com> writes:
>
>> Makefile-based builds can configure Git's internal HTML_PATH by defining
>> htmldir, which is useful for packagers that put documentation in
>> different locations. Gentoo, for example, uses version-suffixed
>> directories like ${prefix}/share/doc/git-2.51 and puts the HTML
>> documentation in an 'html' subdirectory of the same.
>>
>> Propagate the same configuration knob to Meson-based builds so that
>> "git --html-path" on such systems can be configured to output the
>> correct directory.
>>
>> Signed-off-by: D. Ben Knoble <ben.knoble+github@gmail•com>
>> ---
>
> Makes sense (a more meson-minded person needs to double check my
> knee-jerk reaction, though). It is surprising that
>
> $ git grep "dir', " meson_options.txt
> meson_options.txt:option('perllibdir', type: 'string', value: '',
>
> has only a single hit (now two), though. I thought we have a lot
> more flexibility in our build process.
I learned just enough Meson to write this; many of the other “dir” options are builtin for it. Try “meson configure”
>
> I am also a bit surprised that these things are of type 'string'; I
> somehow was expecting that more modern build system would offer
> richer (relative to Makefile, that is) types like 'filename' or
> 'path'.
Yea. At least there is a / operator to concatenate paths, but it looks like they are just strings on either side.
>
>> I've tested this with a modified live Gentoo ebuild [1] and had good results.
>
> Thanks. Will queue and wait for others to chime in.
Looking forward to it.
next prev parent reply other threads:[~2025-11-04 16:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-04 13:58 [PATCH] meson: make GIT_HTML_PATH configurable D. Ben Knoble
2025-11-04 14:41 ` Junio C Hamano
2025-11-04 16:47 ` Ben Knoble [this message]
2025-11-06 7:51 ` Patrick Steinhardt
2025-11-06 7:51 ` Patrick Steinhardt
2025-11-06 14:08 ` Ben Knoble
2025-11-06 15:29 ` Junio C Hamano
2025-11-11 0:25 ` D. Ben Knoble
2025-11-11 13:43 ` Karthik Nayak
2025-11-11 18:52 ` D. Ben Knoble
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0423F0C4-D0AD-471D-9315-FB208A8171B4@gmail.com \
--to=ben.knoble@gmail$(echo .)com \
--cc=ben.knoble+github@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=ps@pks$(echo .)im \
--cc=tmz@pobox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox