public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Phillip Wood <phillip.wood123@gmail•com>
To: Ayush Jha <kumarayushjha123@gmail•com>, git@vger•kernel.org
Cc: Christian Couder <christian.couder@gmail•com>,
	Karthik Nayak <karthik.188@gmail•com>,
	Justin Tobler <jltobler@gmail•com>,
	Ayush Chandekar <ayu.chandekar@gmail•com>,
	Siddharth Asthana <siddharthasthana31@gmail•com>,
	Lucas Seiki Oshiro <lucasseikioshiro@gmail•com>
Subject: Re: [RFC GSoC PATCH v3 0/2] Make read_attr() repository-aware by introducing a lazy bare state
Date: Thu, 19 Feb 2026 10:42:24 +0000	[thread overview]
Message-ID: <0d6c5b14-1c53-4372-8395-7c7cba9fbf0b@gmail.com> (raw)
In-Reply-To: <20260208062949.596-1-kumarayushjha123@gmail.com>

Hi Ayush

On 08/02/2026 06:29, Ayush Jha wrote:
> This patch series is v3 of an earlier RFC that aimed to remove the
> dependency on the global `the_repository` from read_attr().
> 
> Based on feedback from Lucas Seiki Oshiro and Junio C Hamano, this
> iteration introduces a repository-scoped, lazily initialized "bare"
> state in struct repo_settings, exposed via repo_settings_get_is_bare().
> The read_attr() function is then updated to use this helper instead of
> is_bare_repository().

Doesn't the lazy initialization here suffer from the same problems that 
Junio explained in https://lore.kernel.org/xmqqpl63b2tm.fsf@gitster.g ? 
Changing config settings that are currently parsed eagerly to being 
parsed lazily opens up a whole can of worms and is best avoided. As 
Junio said Bello Olamide is exploring a different approach that avoids 
the lazy parsing.

Thanks

Phillip

> The series is split as follows:
>    1/2 repo-settings: add repo_settings_get_is_bare
>    2/2 attr: use local repository state in read_attr
> 
> Comments and suggestions are welcome.
> 
> Ayush Jha (2):
>    repo-settings: add repo_settings_get_is_bare
>    attr: use local repository state in read_attr
> 
>   attr.c          |  3 ++-
>   repo-settings.c | 12 ++++++++++++
>   repo-settings.h |  5 +++++
>   3 files changed, 19 insertions(+), 1 deletion(-)
> 

next prev parent reply	other threads:[~2026-02-19 10:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-08  6:29 [RFC GSoC PATCH v3 0/2] Make read_attr() repository-aware by introducing a lazy bare state Ayush Jha
2026-02-19  9:42 ` Ayush Jha
2026-02-19 10:42 ` Phillip Wood [this message]
2026-02-19 15:01   ` Ayush Jha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0d6c5b14-1c53-4372-8395-7c7cba9fbf0b@gmail.com \
    --to=phillip.wood123@gmail$(echo .)com \
    --cc=ayu.chandekar@gmail$(echo .)com \
    --cc=christian.couder@gmail$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=jltobler@gmail$(echo .)com \
    --cc=karthik.188@gmail$(echo .)com \
    --cc=kumarayushjha123@gmail$(echo .)com \
    --cc=lucasseikioshiro@gmail$(echo .)com \
    --cc=phillip.wood@dunelm$(echo .)org.uk \
    --cc=siddharthasthana31@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox