From: Martin Schlemmer <azarah@nosferatu•za.org>
To: Petr Baudis <pasky@ucw•cz>
Cc: kyle@marchex•com, GIT Mailing Lists <git@vger•kernel.org>
Subject: Re: [patch] fixup GECOS handling
Date: Sun, 24 Apr 2005 01:49:16 +0200 [thread overview]
Message-ID: <1114300156.27940.22.camel@nosferatu.lan> (raw)
In-Reply-To: <20050423233821.GN13222@pasky.ji.cz>
[-- Attachment #1: Type: text/plain, Size: 1681 bytes --]
On Sun, 2005-04-24 at 01:38 +0200, Petr Baudis wrote:
> Dear diary, on Fri, Apr 22, 2005 at 09:06:43PM CEST, I got a letter
> where Martin Schlemmer <azarah@nosferatu•za.org> told me that...
> > @@ -311,6 +296,17 @@
> > if (!pw)
> > die("You don't exist. Go away!");
> > realgecos = pw->pw_gecos;
> > + /*
> > + * The GECOS fields are seperated via ',' on Linux, FreeBSD, etc,
> > + * and ';' on AIX.
> > + */
> > +#if defined(__aix__)
> > + if (strchr(realgecos, ';'))
> > + *strchr(realgecos, ';') = 0;
> > +#else
> > + if (strchr(realgecos, ','))
> > + *strchr(realgecos, ',') = 0;
> > +#endif
> > len = strlen(pw->pw_name);
> > memcpy(realemail, pw->pw_name, len);
> > realemail[len] = '@';
>
> I'm confused, what does this has to do with AIX? Do we even have / can
> expect to have any major AIX users?
>
Given.
> I'm not too happy with this, I have to say. It seems it won't do always
> the right thing anyway. I would still favour the approach when you cut
> off everything after ';', and everything after ',' if no ';' is found.
> Seems simplest, safest, etc.
>
> Tell me about anyone who has a semicolon in his realname.
>
Point I guess is still that the only valid delimiter on linux is ',',
and the only reason for the ';' was because of some aix/whatever user
saying that is a delimiter as well. But like I said: cat $this
> /dev/null ... This is basically the same type of discussion as the
hash collision one, and I'm sure we all have better things to do.
Thanks,
--
Martin Schlemmer
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2005-04-23 23:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-18 10:36 [patch] fixup GECOS handling Martin Schlemmer
2005-04-18 12:35 ` David Woodhouse
2005-04-18 12:58 ` Martin Schlemmer
2005-04-22 14:23 ` Martin Schlemmer
2005-04-22 16:16 ` Kyle Hayes
2005-04-22 16:58 ` Martin Schlemmer
2005-04-22 17:18 ` Petr Baudis
2005-04-22 17:25 ` Martin Schlemmer
2005-04-22 17:58 ` Kyle Hayes
2005-04-22 19:06 ` Martin Schlemmer
2005-04-22 20:46 ` Kyle Hayes
2005-04-23 23:38 ` Petr Baudis
2005-04-23 23:49 ` Martin Schlemmer [this message]
2005-04-22 17:43 ` Kyle Hayes
2005-04-22 23:30 ` Andy Isaacson
2005-04-25 17:02 ` Kyle Hayes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1114300156.27940.22.camel@nosferatu.lan \
--to=azarah@nosferatu$(echo .)za.org \
--cc=git@vger$(echo .)kernel.org \
--cc=kyle@marchex$(echo .)com \
--cc=pasky@ucw$(echo .)cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox