From: "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail•com>
To: "Koji Nakamaru via GitGitGadget" <gitgitgadget@gmail•com>,
git@vger•kernel.org
Cc: "Junio C Hamano" <gitster@pobox•com>,
"D. Ben Knoble" <ben.knoble@gmail•com>,
"Koji Nakamaru" <koji.nakamaru@gree•net>
Subject: Re: [PATCH v3] osxkeychain: define build targets in the top-level Makefile.
Date: Wed, 18 Feb 2026 17:09:38 +0100 [thread overview]
Message-ID: <11a91368-7dc8-4081-bd13-d208126beb7b@app.fastmail.com> (raw)
In-Reply-To: <pull.2046.v3.git.1771391650713.gitgitgadget@gmail.com>
On Wed, Feb 18, 2026, at 06:14, Koji Nakamaru via GitGitGadget wrote:
> From: Koji Nakamaru <koji.nakamaru@gree•net>
>
> The fix for git-credential-osxkeychain in 4580bcd235 (osxkeychain: avoid
> incorrectly skipping store operation) introduced linkage with libgit.a,
Nitpick: Commit references should have the date:
4580bcd235 (osxkeychain: avoid incorrectly skipping store operation, 2025-11-14)
Like the rest of the commits you reference here.
> and its Makefile was adjusted accordingly. However, the build fails as
> of 864f55e190 because several macOS-specific refinements were applied to
> the top-level Makefile and config.mak.uname, such as:
>
> - 363837afe7 (macOS: make Homebrew use configurable, 2025-12-24)
> - cee341e9dd (macOS: use iconv from Homebrew if needed and present,
> 2025-12-24)
> - d281241518 (utf8.c: enable workaround for iconv under macOS 14/15,
> 2026-01-12)
>[snip]
next prev parent reply other threads:[~2026-02-18 16:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-10 18:01 [PATCH] osxkeychain: define build targets in the top-level Makefile Koji Nakamaru via GitGitGadget
2026-02-10 19:50 ` Junio C Hamano
2026-02-10 23:16 ` Koji Nakamaru
2026-02-11 1:59 ` [PATCH v2] " Koji Nakamaru via GitGitGadget
2026-02-11 15:37 ` Junio C Hamano
2026-02-11 23:06 ` Koji Nakamaru
2026-02-16 23:45 ` D. Ben Knoble
2026-02-17 1:09 ` Koji Nakamaru
2026-02-17 13:10 ` D. Ben Knoble
2026-02-17 13:12 ` D. Ben Knoble
2026-02-17 18:05 ` Koji Nakamaru
2026-02-17 21:54 ` D. Ben Knoble
2026-02-18 4:06 ` Koji Nakamaru
2026-02-18 5:14 ` [PATCH v3] " Koji Nakamaru via GitGitGadget
2026-02-18 16:09 ` Kristoffer Haugsbakk [this message]
2026-02-18 19:11 ` Koji Nakamaru
2026-02-18 17:55 ` Junio C Hamano
2026-02-18 19:14 ` Koji Nakamaru
2026-02-19 15:25 ` Junio C Hamano
2026-02-20 1:39 ` [PATCH v4] " Koji Nakamaru via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11a91368-7dc8-4081-bd13-d208126beb7b@app.fastmail.com \
--to=kristofferhaugsbakk@fastmail$(echo .)com \
--cc=ben.knoble@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitgitgadget@gmail$(echo .)com \
--cc=gitster@pobox$(echo .)com \
--cc=koji.nakamaru@gree$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox