From: Johannes Schindelin <Johannes.Schindelin@gmx•de>
To: Johannes Sixt <j6t@kdbg•org>
Cc: Pratyush Yadav <me@yadavpratyush•com>,
git@vger•kernel.org,
Johannes Schindelin via GitGitGadget <gitgitgadget@gmail•com>
Subject: Re: [PATCH v2 2/4] git gui: set GIT_ASKPASS=git-gui--askpass if not set yet
Date: Mon, 17 Nov 2025 15:03:09 +0100 (CET) [thread overview]
Message-ID: <1295d263-e60d-0acb-91ef-9de888398840@gmx.de> (raw)
In-Reply-To: <816cd946-4f25-4ce8-aa06-6babf9e90751@kdbg.org>
Hi Hannes,
On Thu, 28 Aug 2025, Johannes Sixt wrote:
> Am 28.08.25 um 10:58 schrieb Johannes Schindelin via GitGitGadget:
> > @@ -1130,6 +1130,9 @@ set argv0dir [file dirname [file normalize $::argv0]]
> > if {![info exists env(SSH_ASKPASS)]} {
> > set env(SSH_ASKPASS) [file join $argv0dir git-gui--askpass]
> > }
> > +if {![info exists env(GIT_ASKPASS)]} {
> > + set env(GIT_ASKPASS) [gitexec git-gui--askpass]
>
> Is this [gitexec ...] deliberate, or can this be [file join ...] like in
> the surrounding cases? If it is deliberate, we need an updated commit
> message and/or a comment, otherwise, I can amend locally while queuing.
Sorry for the late reply. As you suspected (seeing as you changed it when
integrating sthe patch into your tree), it was just an artifact of
history.
This patch entered Git for Windows back in the msysGit days, in
https://github.com/msysgit/git/commit/1644f8ea0159 (2010-07-23), according
to my records that corresponds to the v1.7.2.3.msysgit.0 timeframe, when
this block was surrounded by similar, `[gitexec]`-using code blocks.
The patch remained virtually unchanged until
https://github.com/git-for-windows/git/commit/076c4bc42171 (2025-06-16),
which still made it into v2.50.0.
Starting with https://github.com/git-for-windows/git/commit/ab11df9a3899
(2025-08-05), this block's context changed, and I must have changed the
block itself in reaction to it in Git for Windows (but I failed to miss it
before sending the patch you reviewed). The patch made it into v2.51.0-rc0
in that new shape, using `[file join ...]` instead of `[gitexec]`.
Luckily, you made the very same adjustment before committing it as
https://github.com/git/git/commit/aeaabebc1a10 (2025-08-28), so all is
good.
Ciao,
Johannes
>
> > +}
> > if {![info exists env(GIT_ASK_YESNO)]} {
> > set env(GIT_ASK_YESNO) [file join $argv0dir git-gui--askyesno]
> > }
>
>
next prev parent reply other threads:[~2025-11-17 14:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-26 15:29 [PATCH 0/4] git-gui: GIT_ASK_YESNO/GIT_ASKPASS patches from Git for Windows Johannes Schindelin via GitGitGadget
2019-09-26 15:29 ` [PATCH 1/4] git-gui: provide question helper for retry fallback on Windows Heiko Voigt via GitGitGadget
2019-09-29 17:11 ` Pratyush Yadav
2019-09-26 15:29 ` [PATCH 2/4] git gui: set GIT_ASKPASS=git-gui--askpass if not set yet Johannes Schindelin via GitGitGadget
2019-09-29 17:15 ` Pratyush Yadav
2019-09-26 15:29 ` [PATCH 3/4] git-gui--askyesno: allow overriding the window title Johannes Schindelin via GitGitGadget
2019-09-29 17:31 ` Pratyush Yadav
2019-09-26 15:30 ` [PATCH 4/4] git-gui--askyesno (mingw): use Git for Windows' icon, if available Johannes Schindelin via GitGitGadget
2019-09-29 18:01 ` Pratyush Yadav
2025-08-28 8:58 ` [PATCH v2 0/4] git-gui: GIT_ASK_YESNO/GIT_ASKPASS patches from Git for Windows Johannes Schindelin via GitGitGadget
2025-08-28 8:58 ` [PATCH v2 1/4] git-gui: provide question helper for retry fallback on Windows Heiko Voigt via GitGitGadget
2025-08-28 8:58 ` [PATCH v2 2/4] git gui: set GIT_ASKPASS=git-gui--askpass if not set yet Johannes Schindelin via GitGitGadget
2025-08-28 17:44 ` Johannes Sixt
2025-11-17 14:03 ` Johannes Schindelin [this message]
2025-08-28 8:58 ` [PATCH v2 3/4] git-gui--askyesno: allow overriding the window title Johannes Schindelin via GitGitGadget
2025-08-28 8:58 ` [PATCH v2 4/4] git-gui--askyesno (mingw): use Git for Windows' icon, if available Johannes Schindelin via GitGitGadget
2025-08-28 13:33 ` [PATCH] git-gui: use tk_messageBox for ask yes/no Mark Levedahl
2025-08-28 13:49 ` Johannes Schindelin
2025-08-28 21:18 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295d263-e60d-0acb-91ef-9de888398840@gmx.de \
--to=johannes.schindelin@gmx$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
--cc=gitgitgadget@gmail$(echo .)com \
--cc=j6t@kdbg$(echo .)org \
--cc=me@yadavpratyush$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox