From: Carl Michael Skog <cmskog@gmail•com>
To: git@vger•kernel.org
Cc: Thomas Rast <trast@student•ethz.ch>,
Carl Michael Skog <cmskog@gmail•com>
Subject: [PATCH] Test failure when spaces in git root
Date: Thu, 24 Mar 2011 01:11:46 +0100 [thread overview]
Message-ID: <1300925506-20378-1-git-send-email-cmskog@gmail.com> (raw)
Some of the svn related tests would break when the git root path had
spaces in it.
The test checks in t/t9119-git-svn-info.sh where falsely assuming that
the only space where in the path of the generated subversion repository.
This will break when the actual git build repository has spaces in it.
Add a global modifier to the sed command that generates the expected
value for the tests.
Signed-off-by: Carl Michael Skog <cmskog@gmail•com>
---
t/t9119-git-svn-info.sh | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/t/t9119-git-svn-info.sh b/t/t9119-git-svn-info.sh
index ff19695..752bf26 100755
--- a/t/t9119-git-svn-info.sh
+++ b/t/t9119-git-svn-info.sh
@@ -28,7 +28,7 @@ test_cmp_info () {
rm -f tmp.expect tmp.actual
}
-quoted_svnrepo="$(echo $svnrepo | sed 's/ /%20/')"
+quoted_svnrepo="$(echo $svnrepo | sed 's/ /%20/g')"
test_expect_success 'setup repository and import' '
mkdir info &&
--
1.7.4.1.99.g3d9132
next reply other threads:[~2011-03-24 0:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-24 0:11 Carl Michael Skog [this message]
2011-03-24 20:46 ` [PATCH] Test failure when spaces in git root Thomas Rast
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300925506-20378-1-git-send-email-cmskog@gmail.com \
--to=cmskog@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=trast@student$(echo .)ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox