Subject: Re: [PATCH] git-send-email: fix missing space in error message

From: Sylvain Rabot <[email-masked]>
Date: Sat, 30 Apr 2011 09:52:39 +0200

Sorry about that. Was thinking this was not worth an entry in
the release note.

On Fri, 2011-04-29 at 11:33 -0700, Junio C Hamano wrote:
> Sylvain Rabot <[email-masked]> writes:
> 
> > Signed-off-by: Sylvain Rabot <[email-masked]>
> 
> Please keep in mind that these individual commits will eventually need an
> entry added to Documentation/Relnotes/1.7.5.1.txt where I describe what
> bug was fixed in a single paragraph, and it almost always talks about how
> a bug would have been triggered so that the readers can tell if the fix
> would benefit them.
> 
> It would have been perfect if you wrote under what condition the user
> would see this error message in the body of the commit.
> 
> > ---
> >  git-send-email.perl |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/git-send-email.perl b/git-send-email.perl
> > index 76565de..98ab33a 100755
> > --- a/git-send-email.perl
> > +++ b/git-send-email.perl
> > @@ -1091,7 +1091,7 @@ X-Mailer: git-send-email $gitversion
> >  			    "VALUES: server=$smtp_server ",
> >  			    "encryption=$smtp_encryption ",
> >  			    "hello=$smtp_domain",
> > -			    defined $smtp_server_port ? "port=$smtp_server_port" : "";
> > +			    defined $smtp_server_port ? " port=$smtp_server_port" : "";
> 
> If I were writing this from scratch, I probably would have written it
> by having leading SP for all options, perhaps like this:
> 
> 	"VALUES:",
>         " option=value",
>         " option=value",
>         (showoption) ? " option=value" : "",
>         (showoption) ? " option=value" : "",
>         ...
> 
> Thanks.