Subject: Re: [PATCH v7 29/33] setup: configure ref storage on setup

From: David Turner <[email-masked]>
Date: Tue, 01 Mar 2016 14:16:31 -0500

On Tue, 2016-03-01 at 17:18 +0000, Ramsay Jones wrote:
> 
> On 01/03/16 00:53, David Turner wrote:
> > This sets up the existing backend early, so that other code which
> > reads refs is reading from the right place.
> > 
> > Signed-off-by: David Turner <[email-masked]>
> > Signed-off-by: Junio C Hamano <[email-masked]>
> > ---
> >  config.c | 1 +
> >  setup.c  | 4 ++++
> >  2 files changed, 5 insertions(+)
> > 
> > diff --git a/config.c b/config.c
> > index 9ba40bc..cca7e28 100644
> > --- a/config.c
> > +++ b/config.c
> > @@ -11,6 +11,7 @@
> >  #include "strbuf.h"
> >  #include "quote.h"
> >  #include "hashmap.h"
> > +#include "refs.h"
> >  #include "string-list.h"
> >  #include "utf8.h"
> >  
> 
> I was just skimming these patches as they passed by, and this
> caught my eye. If this include is required (eg. to fix a compiler
> warning), then it should probably be in an earlier patch.
> Otherwise, it should be in a later patch, no?

Actually, it's cruft from the previous version of this series :(.  I
looked at the patch and didn't notice that it was in config.c instead
of setup.c.  Oops.  Will remove.