Subject: Re: [PATCH 1/5] git-gui i18n: mark strings for translation

From: Vasco Almeida <[email-masked]>
Date: Mon, 03 Oct 2016 12:57:52 +0000

A Seg, 03-10-2016 às 11:30 +0100, Pat Thoyts escreveu:
> Vasco Almeida <[email-masked]> writes:
> 
> > 
> > Mark strings for translation in lib/index.tcl that were seemingly
> > left behind by 700e560 ("git-gui: Mark forgotten strings for
> > translation.", 2008-09-04) which marks string in
> > do_revert_selection
> > procedure.
> > These strings are passed to unstage_help and add_helper procedures.
> > 
> > Signed-off-by: Vasco Almeida <[email-masked]>
> > ---
> > lib/index.tcl | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/lib/index.tcl b/lib/index.tcl
> > index 74a81a7..3a3e534 100644
> > --- a/lib/index.tcl
> > +++ b/lib/index.tcl
> > @@ -291,7 +291,7 @@ proc do_unstage_selection {} {
> > 
> > 	if {[array size selected_paths] > 0} {
> > 		unstage_helper \
> > -			{Unstaging selected files from commit} \
> > +			[mc "Unstaging selected files from
> > commit"] \
> > 			[array names selected_paths]
> > 	} elseif {$current_diff_path ne {}} {
> > 		unstage_helper \
> > @@ -343,7 +343,7 @@ proc do_add_selection {} {
> > 
> > 	if {[array size selected_paths] > 0} {
> > 		add_helper \
> > -			{Adding selected files} \
> > +			[mc "Adding selected files"] \
> > 			[array names selected_paths]
> > 	} elseif {$current_diff_path ne {}} {
> > 		add_helper \
> > @@ -385,7 +385,7 @@ proc do_add_all {} {
> > 			set paths [concat $paths $untracked_paths]
> > 		}
> > 	}
> > -	add_helper {Adding all changed files} $paths
> > +	add_helper [mc "Adding all changed files"] $paths
> > }
> > 
> > proc revert_helper {txt paths} {
> 
> This series looks good. Especially noticing the misuse of the append
> command. Applied to my pu for now.
> Thank you,

I think Junio Hamano added PATCH 1/5 of this series to Git 'next'
branch and added the Portuguese translation of git-gui too.