From: "Michał Górny" <mgorny@gentoo•org>
To: "brian m. carlson" <sandals@crustytoothpaste•net>
Cc: git@vger•kernel.org, Junio C Hamano <gitster@pobox•com>,
Derrick Stolee <stolee@gmail•com>
Subject: Re: [PATCH 2/2] t/t7510-signed-commit.sh: add signing subkey to Eris Discordia key
Date: Sun, 04 Nov 2018 17:07:34 +0100 [thread overview]
Message-ID: <1541347654.22217.4.camel@gentoo.org> (raw)
In-Reply-To: <20181104151013.GH731755@genre.crustytoothpaste.net>
[-- Attachment #1: Type: text/plain, Size: 1937 bytes --]
On Sun, 2018-11-04 at 15:10 +0000, brian m. carlson wrote:
> On Sun, Nov 04, 2018 at 10:47:10AM +0100, Michał Górny wrote:
> > diff --git a/t/t7510-signed-commit.sh b/t/t7510-signed-commit.sh
> > index e8377286d..86d3f93fa 100755
> > --- a/t/t7510-signed-commit.sh
> > +++ b/t/t7510-signed-commit.sh
> > @@ -197,9 +197,9 @@ test_expect_success GPG 'show bad signature with custom format' '
> > test_expect_success GPG 'show untrusted signature with custom format' '
> > cat >expect <<-\EOF &&
> > U
> > - 61092E85B7227189
> > + 65A0EEA02E30CAD7
> > Eris Discordia <discord@example•net>
> > - D4BE22311AD3131E5EDA29A461092E85B7227189
> > + F8364A59E07FFE9F4D63005A65A0EEA02E30CAD7
> > D4BE22311AD3131E5EDA29A461092E85B7227189
> > EOF
> > git log -1 --format="%G?%n%GK%n%GS%n%GF%n%GP" eighth-signed-alt >actual &&
> > @@ -209,7 +209,7 @@ test_expect_success GPG 'show untrusted signature with custom format' '
> > test_expect_success GPG 'show unknown signature with custom format' '
> > cat >expect <<-\EOF &&
> > E
> > - 61092E85B7227189
> > + 65A0EEA02E30CAD7
>
> It's my understanding that GnuPG will use the most recent subkey
> suitable for a particular purpose, and I think the test relies on that
> behavior. However, I'm not sure that's documented. Do we want to rely
> on that behavior or be more explicit? (This is a question, not an
> opinion.)
To be honest, I don't recall which suitable subkey is used. However, it
definitely will prefer a subkey with signing capabilities over
the primary key if one is present, and this is well-known and expected
behavior.
In fact, if you have a key with two signing subkeys A and B and it
considers A better, then even if you explicitly pass keyid of B, it will
use A. To force another subkey you have to append '!' to keyid.
Therefore, I think this is a behavior we can rely on.
--
Best regards,
Michał Górny
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 963 bytes --]
next prev parent reply other threads:[~2018-11-04 16:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-04 9:47 [PATCH 1/2] t/t7510-signed-commit.sh: Add %GP to custom format checks Michał Górny
2018-11-04 9:47 ` [PATCH 2/2] t/t7510-signed-commit.sh: add signing subkey to Eris Discordia key Michał Górny
2018-11-04 15:10 ` brian m. carlson
2018-11-04 16:07 ` Michał Górny [this message]
2018-11-05 1:08 ` Junio C Hamano
2018-11-05 4:09 ` Michał Górny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1541347654.22217.4.camel@gentoo.org \
--to=mgorny@gentoo$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=sandals@crustytoothpaste$(echo .)net \
--cc=stolee@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox