From: Johannes Sixt <j6t@kdbg•org>
To: Derrick Stolee <stolee@gmail•com>
Cc: gitster@pobox•com, git@vger•kernel.org,
Derrick Stolee via GitGitGadget <gitgitgadget@gmail•com>
Subject: Re: [PATCH] revision: add --maximal option
Date: Sun, 18 Jan 2026 10:05:30 +0100 [thread overview]
Message-ID: <1da38e88-3f61-43df-9c75-5716d715bf80@kdbg.org> (raw)
In-Reply-To: <pull.2032.git.1768703645125.gitgitgadget@gmail.com>
Am 18.01.26 um 03:34 schrieb Derrick Stolee via GitGitGadget:
> diff --git a/Documentation/rev-list-options.adoc b/Documentation/rev-list-options.adoc
> index 453ec59057..f0d2ab32a9 100644
> --- a/Documentation/rev-list-options.adoc
> +++ b/Documentation/rev-list-options.adoc
> @@ -444,6 +444,10 @@ The following options affect the way the simplification is performed:
> times; if so, a commit is included if it is any of the commits
> given or if it is an ancestor or descendant of one of them.
>
> +`--maximal`::
> + Restrict the output commits to be those that are not reachable
> + from any other commits in the revision range.
I had to read this sentence three times to understand what it wants to
say, and that even though I had a rough idea what it was supposed to
mean. I tried to come up with a better wording, but found it to be
really hard.
Restrict output to the commits at the tips of the
revision range.
is all I could do, but this isn't a lot better, I am afraid.
The option name is too generic IMHO. How about "--starting-point",
"--topmost-only"? It's function is somewhat parallel to --boundary, but
at the positive end of the revision range. Perhaps we can use that as
inspiration.
The option is listed among options that affect the way the
simplification is performed. But is this true? Isn't it just an option
that changes what output is produced?
-- Hannes
next prev parent reply other threads:[~2026-01-18 9:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-18 2:34 [PATCH] revision: add --maximal option Derrick Stolee via GitGitGadget
2026-01-18 9:05 ` Johannes Sixt [this message]
2026-01-18 18:27 ` Derrick Stolee
2026-01-19 11:15 ` Johannes Sixt
2026-01-19 16:44 ` Derrick Stolee
2026-01-19 19:05 ` Johannes Sixt
2026-01-20 0:22 ` Junio C Hamano
2026-01-22 15:08 ` Derrick Stolee
2026-01-22 16:05 ` [PATCH v2] revision: add --maximal-only option Derrick Stolee via GitGitGadget
2026-01-22 21:44 ` Junio C Hamano
2026-01-22 22:15 ` Derrick Stolee
2026-01-22 23:11 ` Junio C Hamano
2026-01-23 6:38 ` Johannes Sixt
2026-01-23 15:58 ` Junio C Hamano
2026-01-23 16:55 ` Derrick Stolee
2026-01-23 18:08 ` Junio C Hamano
2026-01-28 14:28 ` Derrick Stolee
2026-01-29 0:14 ` Junio C Hamano
2026-01-29 14:57 ` Derrick Stolee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1da38e88-3f61-43df-9c75-5716d715bf80@kdbg.org \
--to=j6t@kdbg$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
--cc=gitgitgadget@gmail$(echo .)com \
--cc=gitster@pobox$(echo .)com \
--cc=stolee@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox