From: Jonas Fonseca <fonseca@diku•dk>
To: Petr Baudis <pasky@ucw•cz>
Cc: git@vger•kernel.org
Subject: [PATCH 1/10] Cleanup conversion to human readable date
Date: Sat, 4 Jun 2005 16:39:06 +0200 [thread overview]
Message-ID: <20050604143906.GE12615@diku.dk> (raw)
In-Reply-To: <20050604143831.GD12615@diku.dk>
Simplify the date substitution to reduce code duplication.
Signed-off-by: Jonas Fonseca <fonseca@diku•dk>
---
cg-log | 8 ++------
cg-mkpatch | 7 ++-----
2 files changed, 4 insertions(+), 11 deletions(-)
diff --git a/cg-log b/cg-log
--- a/cg-log
+++ b/cg-log
@@ -188,12 +188,8 @@ $revls | $revsort | while read time comm
date=(${rest#*> })
pdate="$(showdate $date)"
- if [ "$pdate" ]; then
- echo -n $color$key $rest | sed "s/>.*/> $pdate/"
- echo $coldefault
- else
- echo $color$key $rest $coldefault
- fi
+ [ "$pdate" ] && rest="${rest%> *}> $pdate"
+ echo $color$key $rest $coldefault
;;
"tree"|"parent")
if [ -z $tree1 ]; then
diff --git a/cg-mkpatch b/cg-mkpatch
--- a/cg-mkpatch
+++ b/cg-mkpatch
@@ -53,11 +53,8 @@ showpatch () {
"author"|"committer")
date=(${rest#*> })
pdate="$(showdate $date)"
- if [ "$pdate" ]; then
- echo $key $rest | sed "s/>.*/> $pdate/" >>$header
- else
- echo $key $rest >>$header
- fi
+ [ "$pdate" ] && rest="${rest%> *}> $pdate"
+ echo $key $rest >>$header
;;
"")
cat
--
Jonas Fonseca
next prev parent reply other threads:[~2005-06-04 14:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-04 14:38 [PATCHSET] cg-log cleanups and enhancements Jonas Fonseca
2005-06-04 14:39 ` Jonas Fonseca [this message]
2005-06-04 14:39 ` [PATCH 2/10] Separate handling of tree and parent in commit headers Jonas Fonseca
2005-06-04 14:40 ` [PATCH 3/10] Separate handling of author and committer " Jonas Fonseca
2005-06-04 14:40 ` [PATCH 4/10] First parse all commit header entries then print them Jonas Fonseca
2005-06-04 14:41 ` [PATCH 5/10] Move printing of the commit info line inside the loop Jonas Fonseca
2005-06-04 14:41 ` [PATCH 6/10] Remove the catch all rule Jonas Fonseca
2005-06-04 14:42 ` [PATCH 7/10] Move log printing to separate function Jonas Fonseca
2005-06-04 14:42 ` [PATCH 8/10] Move the username matching inside the loop Jonas Fonseca
2005-06-04 14:43 ` [PATCH 9/10] Move file " Jonas Fonseca
2005-06-04 14:43 ` [PATCH 10/10] Add -s option to show log summary Jonas Fonseca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050604143906.GE12615@diku.dk \
--to=fonseca@diku$(echo .)dk \
--cc=git@vger$(echo .)kernel.org \
--cc=pasky@ucw$(echo .)cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox