public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Erik Mouw <erik@harddisk-recovery•com>
To: Jan-Benedict Glaw <jbglaw@lug-owl•de>
Cc: Keith Packard <keithp@keithp•com>,
	Git Mailing List <git@vger•kernel.org>
Subject: Re: parsecvs tool now creates git repositories
Date: Mon, 3 Apr 2006 15:58:34 +0200	[thread overview]
Message-ID: <20060403135834.GD16823@harddisk-recovery.com> (raw)
In-Reply-To: <20060403072554.GN1259@lug-owl.de>

On Mon, Apr 03, 2006 at 09:25:54AM +0200, Jan-Benedict Glaw wrote:
> On Sun, 2006-04-02 21:10:56 -0700, Keith Packard <keithp@keithp•com> wrote:
> > I think this is a bug in your version of flex; I'm using standard lex
> > conventions here. I don't know how to make it work for you.
> 
> It compiles for me with this patch (thanks to Linus for the hint):
> 
> diff --git a/Makefile b/Makefile

[...]

> Would you please verify that it doesn't break things for you?

Almost there. I applied your patch and ran "make clean", but the
Makefile forgets to remove lex.c. Here's an updated patch:

diff --git a/Makefile b/Makefile
index 639353a..5651e70 100644
--- a/Makefile
+++ b/Makefile
@@ -3,7 +3,8 @@ GCC_WARNINGS2=-Wmissing-prototypes -Wmis
 GCC_WARNINGS3=-Wnested-externs -fno-strict-aliasing
 GCC_WARNINGS=$(GCC_WARNINGS1) $(GCC_WARNINGS2) $(GCC_WARNINGS3)
 CFLAGS=-O0 -g $(GCC_WARNINGS)
-YFLAGS=-d
+YFLAGS=-d -l
+LFLAGS=-l
 
 SRCS=gram.y lex.l cvs.h parsecvs.c cvsutil.c revlist.c atom.c revcvs.c git.c
 
@@ -20,4 +21,4 @@ lex.o: lex.c
 y.tab.h: gram.c
 
 clean:
-	rm -f $(OBJS) y.tab.h gram.c parsecvs
+	rm -f $(OBJS) y.tab.h gram.c lex.c parsecvs



It compiles! Ship it! ;-)


Erik

-- 
+-- Erik Mouw -- www.harddisk-recovery.com -- +31 70 370 12 90 --
| Lab address: Delftechpark 26, 2628 XH, Delft, The Netherlands

  reply	other threads:[~2006-04-03 13:58 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-02  5:36 parsecvs tool now creates git repositories Keith Packard
2006-04-02  9:39 ` Jan-Benedict Glaw
2006-04-02 19:31   ` Jan-Benedict Glaw
2006-04-03  4:10     ` Keith Packard
2006-04-03  4:38       ` Linus Torvalds
2006-04-03  7:25       ` Jan-Benedict Glaw
2006-04-03 13:58         ` Erik Mouw [this message]
2006-04-03 16:54         ` Keith Packard
2006-04-03 22:19           ` Keith Packard
2006-04-03 14:03 ` Erik Mouw
2006-04-03 14:21   ` Jakub Narebski
2006-04-03 14:39     ` Keith Packard
2006-04-03 14:37   ` Keith Packard
2006-04-03 15:32     ` Jeff King
2006-04-04  0:55   ` Anand Kumria
2006-04-03 22:38 ` Martin Langhoff
2006-04-04  2:07   ` Keith Packard
2006-04-04  2:16     ` Martin Langhoff
2006-04-04  2:24       ` Keith Packard
2006-04-04  2:42         ` Martin Langhoff
2006-04-04  3:51           ` Keith Packard
2006-04-04  6:09             ` Junio C Hamano
     [not found] <20060405174247.GA29758@blackbean.org>
     [not found] ` <1144262498.2303.231.camel@neko.keithp.com>
2006-04-06  6:36   ` Fixes to parsecvs Keith Packard
2006-04-06 18:15     ` parsecvs tool now creates git repositories Jim Radford
2006-04-06 20:12       ` Keith Packard
2006-04-06 21:51         ` Martin Langhoff
2006-04-06 22:19           ` Keith Packard
2006-04-06 23:22             ` Martin Langhoff
2006-04-07  7:24               ` Keith Packard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060403135834.GD16823@harddisk-recovery.com \
    --to=erik@harddisk-recovery$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=jbglaw@lug-owl$(echo .)de \
    --cc=keithp@keithp$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox