From: Shawn Pearce <spearce@spearce•org>
To: Junio Hamano <junkio@cox•net>
Cc: git@vger•kernel.org
Subject: [PATCH] Make '@' not valid in a ref name.
Date: Sat, 20 May 2006 21:37:51 -0400 [thread overview]
Message-ID: <20060521013751.GA7516@spearce.org> (raw)
Now that the sha1 expression syntax supports looking up a ref's
value at a prior point in time through the '@' operator the '@'
operator should not be permitted in a ref name.
Signed-off-by: Shawn O. Pearce <spearce@spearce•org>
---
90d3212d5351d2f6c6ad33578c9f9df2e07af12e
refs.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
90d3212d5351d2f6c6ad33578c9f9df2e07af12e
diff --git a/refs.c b/refs.c
index eeb1196..2530c99 100644
--- a/refs.c
+++ b/refs.c
@@ -213,14 +213,14 @@ int get_ref_sha1(const char *ref, unsign
*
* - any path component of it begins with ".", or
* - it has double dots "..", or
- * - it has ASCII control character, "~", "^", ":" or SP, anywhere, or
+ * - it has ASCII control character, "@", "~", "^", ":" or SP,
* - it ends with a "/".
*/
static inline int bad_ref_char(int ch)
{
return (((unsigned) ch) <= ' ' ||
- ch == '~' || ch == '^' || ch == ':' ||
+ ch == '@' || ch == '~' || ch == '^' || ch == ':' ||
/* 2.13 Pattern Matching Notation */
ch == '?' || ch == '*' || ch == '[');
}
--
1.3.3.gfad60
next reply other threads:[~2006-05-21 1:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-21 1:37 Shawn Pearce [this message]
2006-05-21 1:42 ` [PATCH] Make '@' not valid in a ref name Junio C Hamano
2006-05-21 1:58 ` Shawn Pearce
2006-05-21 2:00 ` Eric Wong
2006-05-21 2:19 ` Shawn Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060521013751.GA7516@spearce.org \
--to=spearce@spearce$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
--cc=junkio@cox$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox