From: Nick Hengeveld <nickh@reactrix•com>
To: Junio C Hamano <junkio@cox•net>
Cc: Sean <seanlkml@sympatico•ca>, git@vger•kernel.org
Subject: Re: [PATCH] Remove possible segfault in http-fetch.
Date: Wed, 31 May 2006 09:07:31 -0700 [thread overview]
Message-ID: <20060531160731.GA12261@reactrix.com> (raw)
In-Reply-To: <7vverzzukg.fsf@assigned-by-dhcp.cox.net>
On Sun, May 21, 2006 at 12:49:19AM -0700, Junio C Hamano wrote:
> curl_easy_cleanup() which is called from http_cleanup() says it
> is safe to remove the strings _after_ you call that function, so
> I think the change makes sense -- it was apparently unsafe to
> free them before calling cleanup.
>
> Knowing nothing about quirks in curl libraries, one thing that
> is mystery to me is that we slist_append() to other two lists
> (pragma_header and range_header) but we do not seem to ever free
> them. Another slist dav_headers is allocated and then freed
> inside a function, so that call-pattern seems well-formed.
>
> Nick, care to help us out?
I just got back from a trip to the midwest and am still getting caught
up. I was only gone for 10 days, you've all been quite busy...
You're correct wrt the other slists, I'll get to work on a patch for
that after I've caught up.
I'm also doing additional testing to see whether this fixes the DAV/405
segfault as I think there may be something else going on there.
--
For a successful technology, reality must take precedence over public
relations, for nature cannot be fooled.
next prev parent reply other threads:[~2006-05-31 16:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-20 18:47 Segfaults with USE_CURL_MULTI Florian Weimer
[not found] ` <20060520184633.76b438cc.seanlkml@sympatico.ca>
2006-05-20 22:46 ` [PATCH] Remove possible segfault in http-fetch Sean
2006-05-20 23:00 ` Florian Weimer
2006-05-21 7:49 ` Junio C Hamano
2006-05-31 16:07 ` Nick Hengeveld [this message]
2006-05-22 15:56 ` Segfaults with USE_CURL_MULTI Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060531160731.GA12261@reactrix.com \
--to=nickh@reactrix$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=junkio@cox$(echo .)net \
--cc=seanlkml@sympatico$(echo .)ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox