public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Yann Dirson <ydirson@altern•org>
To: Junio C Hamano <junkio@cox•net>
Cc: Martin Langhoff <martin@catalyst•net.nz>, git@vger•kernel.org
Subject: Re: [PATCH] cvsimport: ignore CVSPS_NO_BRANCH and impossible branches
Date: Sat, 17 Jun 2006 23:27:41 +0200	[thread overview]
Message-ID: <20060617212741.GT7766@nowhere.earth> (raw)
In-Reply-To: <7vzmgb8plx.fsf@assigned-by-dhcp.cox.net>

On Sat, Jun 17, 2006 at 02:00:10PM -0700, Junio C Hamano wrote:
> Martin Langhoff <martin@catalyst•net.nz> writes:
> 
> > cvsps output often contains references to CVSPS_NO_BRANCH, commits that it
> > could not trace to a branch. Ignore that branch.
> >
> > Additionally, cvsps will sometimes draw circular relationships between
> > branches -- where two branches are recorded as opening from the other.
> > In those cases, and where the ancestor branch hasn't been seen, ignore
> > it.
> 
> This sounds more like an workaround than a real fix to me,
> although I'd apply it for now.  I see Yann is collecting cvsps
> patches but maybe there will be a real fix soonish?

I have not dig yet into the cases that trigger CVSPS_NO_BRANCH so
can't make any promise, unless someone comes in with a patch already
written :)

Since the patch seems to ensure the user gets warned when a branch
gets ignored this way, allowing it in could probably allow at least
some people to have cvsimport does a partial job, rather than failing
midway.  Maybe a final warning when all patchsets could not be
imported could be issued, so the existing ones do not get simply lost
in the verbose output.

Best regards,
-- 
Yann Dirson    <ydirson@altern•org> |
Debian-related: <dirson@debian•org> |   Support Debian GNU/Linux:
                                    |  Freedom, Power, Stability, Gratis
     http://ydirson.free.fr/        | Check <http://www.debian.org/>

  reply	other threads:[~2006-06-17 21:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-11  8:12 [PATCH] cvsimport: ignore CVSPS_NO_BRANCH and impossible branches Martin Langhoff
2006-06-17 21:00 ` Junio C Hamano
2006-06-17 21:27   ` Yann Dirson [this message]
2006-06-19 16:20   ` Salikh Zakirov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060617212741.GT7766@nowhere.earth \
    --to=ydirson@altern$(echo .)org \
    --cc=git@vger$(echo .)kernel.org \
    --cc=junkio@cox$(echo .)net \
    --cc=martin@catalyst$(echo .)net.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox