Subject: Re: [PATCH] dir: do all size checks before seeking back and fix file closing

From: Jonas Fonseca <[email-masked]>
Date: Sat, 26 Aug 2006 22:44:49 +0200

Mitchell Blank Jr <[email-masked]> wrote Sat, Aug 26, 2006:
> Jonas Fonseca wrote:
> >   err:
> > -	if (0 <= fd)
> > +	if (0 >= fd)
> >  		close(fd);
> 
> Could you explain that piece?  You now only close "fd" if it's zero (stdin)
> or negative (invalid).  The old code (close if its >=0) make more sense.

Ah, yes, sorry for the noise. I read the old code as (fd <= 0).

-- 
Jonas Fonseca