From: Shawn Pearce <spearce@spearce•org>
To: Johannes Schindelin <Johannes.Schindelin@gmx•de>
Cc: Junio C Hamano <junkio@cox•net>, git@vger•kernel.org
Subject: Re: [PATCH 7/7] Replace mmap with xmmap, better handling MAP_FAILED.
Date: Sun, 24 Dec 2006 15:34:48 -0500 [thread overview]
Message-ID: <20061224203448.GB631@spearce.org> (raw)
In-Reply-To: <Pine.LNX.4.63.0612241410400.19693@wbgn013.biozentrum.uni-wuerzburg.de>
Johannes Schindelin <Johannes.Schindelin@gmx•de> wrote:
> All in all it is a good change -- for the builtin programs.
>
> But it is less good for the libification. Maybe it is time for a
> discussion about the possible strategies to avoid dying in libgit.a?
Well we have the same problem with xmalloc. All I've done is move
the MAP_FAILED cases which tend to wind up die()'ing later anyway
into the same scope of area where the xmalloc issue is.
We die() all over the place. ~1312 times according to 'git grep die'.
Git isn't a program for the living. :-)
To properly libify we have a few issues:
- we cannot just exit this process when we run into an error;
- routines need to cleanup temporary resources (memory, file
descriptors) when returning an error;
- static variables like environment.c need to be reorganized to
support multiple repositories in the same program;
- objects need to be able to be deallocated, especially
if the revision walking machinary has done rewriting
Though the die() is the largest issue.
--
Shawn.
prev parent reply other threads:[~2006-12-24 20:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <487c7d0ea81f2f82f330e277e0aea38a66ca7cfe.1166939109.git.spearce@spearce.org>
2006-12-24 5:45 ` [PATCH 2/7] Switch git_mmap to use pread Shawn O. Pearce
2006-12-24 13:09 ` Johannes Schindelin
2006-12-24 19:30 ` Alon Ziv
2006-12-24 20:13 ` Shawn Pearce
2006-12-24 20:14 ` Linus Torvalds
2006-12-24 5:46 ` [PATCH 3/7] Ensure packed_git.next is initialized to NULL Shawn O. Pearce
2006-12-24 5:46 ` [PATCH 4/7] Default core.packdGitWindowSize to 1 MiB if NO_MMAP Shawn O. Pearce
2006-12-24 5:46 ` [PATCH 5/7] Don't exit successfully on EPIPE in read_or_die Shawn O. Pearce
2006-12-24 5:47 ` [PATCH 6/7] Release pack windows before reporting out of memory Shawn O. Pearce
2006-12-24 13:10 ` Johannes Schindelin
2006-12-24 5:47 ` [PATCH 7/7] Replace mmap with xmmap, better handling MAP_FAILED Shawn O. Pearce
2006-12-24 13:22 ` Johannes Schindelin
2006-12-24 20:34 ` Shawn Pearce [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061224203448.GB631@spearce.org \
--to=spearce@spearce$(echo .)org \
--cc=Johannes.Schindelin@gmx$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
--cc=junkio@cox$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox