public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Robin Rosenberg <robin.rosenberg.lists@dewire•com>
To: Junio C Hamano <junkio@cox•net>
Cc: SungHyun Nam <goweol@gmail•com>, git@vger•kernel.org
Subject: Re: GIT 1.5.0-rc2 compiler warning
Date: Mon, 22 Jan 2007 21:44:34 +0100	[thread overview]
Message-ID: <200701222144.34934.robin.rosenberg.lists@dewire.com> (raw)
In-Reply-To: <7vy7nvyic4.fsf@assigned-by-dhcp.cox.net>

måndag 22 januari 2007 02:13 skrev Junio C Hamano:
> I know.  Imported code.
>
> I do not think we can do much on a platform where wchar_t is too
> narrow and BMP only anyway.

What's wrong is the assumption that wchar_t corresponds to a complete unicode 
character. On windows, two wchar_t (code units) may me combined to encode a
unicode character outside of the BMP.

Without investigating further, I note that Java adds methods with an 'int' 
argument to the Character utility class to handle code points, vs the 
original 'char' that represents a code unit. (unlike C, an int is always 
32-bit in Java).

-- robin
 

      reply	other threads:[~2007-01-22 20:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-22  1:08 GIT 1.5.0-rc2 compiler warning SungHyun Nam
2007-01-22  1:13 ` Junio C Hamano
2007-01-22 20:44   ` Robin Rosenberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200701222144.34934.robin.rosenberg.lists@dewire.com \
    --to=robin.rosenberg.lists@dewire$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=goweol@gmail$(echo .)com \
    --cc=junkio@cox$(echo .)net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox