public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Andy Parkins <andyparkins@gmail•com>
To: git@vger•kernel.org
Cc: Junio C Hamano <junkio@cox•net>, Nicolas Pitre <nico@cam•org>,
	"Shawn O. Pearce" <spearce@spearce•org>
Subject: Re: [PATCH 1/2] Teach git-describe to display distances from tags.
Date: Fri, 26 Jan 2007 10:36:18 +0000	[thread overview]
Message-ID: <200701261036.26012.andyparkins@gmail.com> (raw)
In-Reply-To: <7vmz4663xq.fsf@assigned-by-dhcp.cox.net>

On Friday 2007 January 26 00:13, Junio C Hamano wrote:

> Hmph.  And an option --no-number to disable this is probably not
> worth it, as it forces the existing scripts that wants the
> tagname to be updated to pass that new option.  If the users
> need to update their scripts anyway, they can sed/expr the
> number out just as easily as passing the new option.

Actually, the more useful switch would be "--tag-only"; then

x=$(git-describe HEAD | sed 's/-g*//')

In scripts could become

x=$(git-describe --tag-only HEAD)

Then, the suffix can be anything we want, and can change in the future without 
affecting these scripts.


Andy
-- 
Dr Andy Parkins, M Eng (hons), MIEE
andyparkins@gmail•com

  parent reply	other threads:[~2007-01-26 10:36 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-25 17:39 [PATCH 1/2] Teach git-describe to display distances from tags Shawn O. Pearce
2007-01-25 21:26 ` Junio C Hamano
2007-01-25 21:37   ` Shawn O. Pearce
2007-01-25 21:42   ` Junio C Hamano
2007-01-25 21:49     ` Shawn O. Pearce
2007-01-25 23:32       ` Nicolas Pitre
2007-01-26  0:13         ` Junio C Hamano
2007-01-26  8:52           ` Francis Moreau
2007-01-26  9:00             ` Junio C Hamano
2007-01-26  9:39               ` Francis Moreau
2007-01-26  9:51                 ` Shawn O. Pearce
2007-01-26 10:36           ` Andy Parkins [this message]
2007-01-26 14:28             ` [PATCH] If abbrev is set to zero in git-describe, don't add the unique suffix Andy Parkins
2007-01-26 13:33 ` [PATCH 1/2] Teach git-describe to display distances from tags Jakub Narebski
2007-01-26 19:37   ` Matthias Lederhofer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200701261036.26012.andyparkins@gmail.com \
    --to=andyparkins@gmail$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=junkio@cox$(echo .)net \
    --cc=nico@cam$(echo .)org \
    --cc=spearce@spearce$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox