From: "Shawn O. Pearce" <spearce@spearce•org>
To: Johannes Schindelin <Johannes.Schindelin@gmx•de>
Cc: Junio C Hamano <junkio@cox•net>, git@vger•kernel.org
Subject: Re: [PATCH 3/4] Teach git-describe to display distances from tags.
Date: Sun, 28 Jan 2007 02:24:49 -0500 [thread overview]
Message-ID: <20070128072449.GA9781@spearce.org> (raw)
In-Reply-To: <Pine.LNX.4.63.0701271348330.22628@wbgn013.biozentrum.uni-wuerzburg.de>
Johannes Schindelin <Johannes.Schindelin@gmx•de> wrote:
> On Sat, 27 Jan 2007, Junio C Hamano wrote:
> > "Shawn O. Pearce" <spearce@spearce•org> writes:
> >
> > > The + format is much easier to read and understand than the - format
> > > original proposed by Junio.
> >
> > I tend to disagree (I do not claim + is _less_ easier to read, though).
> >
> > They are of comparable readability, and I think plus breaks
> > GIT-VERSION-GEN (the primary reason it replaces '-' to '.' is to work
> > around RPM limitation IIRC, and I do not know what '+' does to RPM
> > offhand).
>
> Note that scripts using git-describe to name archives break also on
> challenged file / operating systems. IIRC on DOS/FAT32 '+' has problems
> with it.
>
> > But I do not have a strong feeling either way.
>
> Neither have I.
Me neither, actually. The + just felt more right, as its literally
"that tag, plus n commits".
But if + is going to cause pain on operating systems that somehow
decided disallowing bytes other than NUL was OK and the right thing
to do, then maybe - is the safer choice here.
--
Shawn.
next prev parent reply other threads:[~2007-01-28 7:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <a23c4e55ca5c09f742fa2a047e45613e7797e720.1169880681.git.spearce@spearce.org>
2007-01-27 6:53 ` [PATCH 2/4] If abbrev is set to zero in git-describe, don't add the unique suffix Shawn O. Pearce
2007-01-27 6:54 ` [PATCH 3/4] Teach git-describe to display distances from tags Shawn O. Pearce
2007-01-27 8:47 ` Junio C Hamano
2007-01-27 12:50 ` Johannes Schindelin
2007-01-28 7:24 ` Shawn O. Pearce [this message]
2007-01-27 6:54 ` [PATCH 4/4] Compute accurate distances in git-describe before output Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070128072449.GA9781@spearce.org \
--to=spearce@spearce$(echo .)org \
--cc=Johannes.Schindelin@gmx$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
--cc=junkio@cox$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox