From: "Shawn O. Pearce" <spearce@spearce•org>
To: Junio C Hamano <junkio@cox•net>
Cc: Mark Levedahl <mdl123@verizon•net>, git@vger•kernel.org
Subject: Re: [PATCH] Add git-bundle - pack objects and references for disconnected transfer
Date: Thu, 15 Feb 2007 23:41:58 -0500 [thread overview]
Message-ID: <20070216044158.GB28894@spearce.org> (raw)
In-Reply-To: <7vodnuc0me.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano <junkio@cox•net> wrote:
> Mark Levedahl <mdl123@verizon•net> writes:
> > +# we do things a slow way if max-age or min-age are given
> > +fast=
> > +[ "${fullrevargs##*--max-age}" == "$fullrevargs" ] && \
> > +[ "${fullrevargs##*--min-age}" == "$fullrevargs" ] && fast=1
>
> Style.
>
> Our scripts tend to spell the test command "test" and equality test
> operator as single '='.
Using "test" is a style thing, but using "=" rather than "==" is
a portability issue. "==" is accepted by bash as a synonym for
"=", but its not valid elsewhere.
I've made my fair share of patches with "==" in them, only to have
someone else have a problem on their system and then submit a fix to
change them to "=". Just say no to "==" in Git shell scripts. ;-)
> > + # get immediate parents of each commit to include
> > + parents=
> > + for c in $commits ; do
> > + parents="$parents $(git-rev-list --parents $c | head -1 | cut -b42-)"
> > + done
>
> Nicely done, but you seemed to have used "head -n 1" elsewhere,
> which is more portable.
What about:
parents="$parents $(git-rev-list --max-count=1 --parents $c | cut -b42-)"
?
I just used that trick recently. Oh yea it was in git-gui's
GIT-VERSION-GEN script. Though I did not know about using cut
like that...
--
Shawn.
next prev parent reply other threads:[~2007-02-16 4:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-16 0:19 Respun - Scripts to use bundles to move data between repos Mark Levedahl
2007-02-16 0:19 ` [PATCH] Add git-bundle - pack objects and references for disconnected transfer Mark Levedahl
2007-02-16 0:19 ` [PATCH] Add git-unbundle - unpack " Mark Levedahl
2007-02-16 0:19 ` [PATCH] Include git-bundle and git-unbundle in Makefile Mark Levedahl
2007-02-16 0:19 ` [PATCH] Create documentation for git-bundle Mark Levedahl
2007-02-16 0:19 ` [PATCH] Create documentation for git-unbundle Mark Levedahl
2007-02-16 0:19 ` [PATCH] Link git-bundle and git-unbundle docs from git(7) Mark Levedahl
2007-02-16 2:24 ` [PATCH] Add git-unbundle - unpack objects and references for disconnected transfer Junio C Hamano
2007-02-16 2:40 ` Linus Torvalds
2007-02-16 6:38 ` Mark Levedahl
2007-02-16 6:48 ` Shawn O. Pearce
2007-02-16 7:31 ` Junio C Hamano
2007-02-16 7:45 ` Shawn O. Pearce
2007-02-16 6:22 ` Mark Levedahl
2007-02-16 7:24 ` Junio C Hamano
2007-02-16 2:11 ` [PATCH] Add git-bundle - pack " Junio C Hamano
2007-02-16 4:41 ` Shawn O. Pearce [this message]
2007-02-16 7:28 ` Junio C Hamano
2007-02-16 6:39 ` Mark Levedahl
2007-02-16 6:54 ` Shawn O. Pearce
2007-02-16 11:57 ` Simon 'corecode' Schubert
2007-02-16 4:37 ` Respun - Scripts to use bundles to move data between repos Shawn O. Pearce
-- strict thread matches above, loose matches on Subject: below --
2007-02-16 12:45 Re: [PATCH] Add git-bundle - pack objects and references for disconnected transfer Mark Levedahl
2007-02-16 13:25 ` Simon 'corecode' Schubert
2007-02-16 13:44 ` Johannes Schindelin
2007-02-16 23:25 ` Mark Levedahl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070216044158.GB28894@spearce.org \
--to=spearce@spearce$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
--cc=junkio@cox$(echo .)net \
--cc=mdl123@verizon$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox