From: "Shawn O. Pearce" <spearce@spearce•org>
To: Johannes Schindelin <Johannes.Schindelin@gmx•de>
Cc: Mark Levedahl <mdl123@verizon•net>, git@vger•kernel.org
Subject: Re: [PATCH] Add git-bundle: move objects and references by archive.
Date: Mon, 19 Feb 2007 02:56:54 -0500 [thread overview]
Message-ID: <20070219075654.GB30030@spearce.org> (raw)
In-Reply-To: <Pine.LNX.4.63.0702190126220.22628@wbgn013.biozentrum.uni-wuerzburg.de>
Johannes Schindelin <Johannes.Schindelin@gmx•de> wrote:
> On Sun, 18 Feb 2007, Mark Levedahl wrote:
> > + gitrevargs=$(git-rev-parse --symbolic --revs-only $args) || exit 1
>
> Here, you rely again on the refs not containing spaces.
They cannot. OK, they can if you avoid any of the Git code:
git rev-parse HEAD >".git/refs/heads/ref with space"
but a lot of things downstream may get annoyed by doing this.
Spaces are not permitted in ref names.
> > + # create refs and pack
> > + tmp="$GIT_DIR/bundle_tmp$$"
>
> Should we really rely on $GIT_DIR being writable? For unbundling, yes, but
> for bundling? Given the great confusion with git-status trying to write
> into $GIT_DIR, and people _demanding_ that it does not do so, I recommend
> against that.
I agree. For an application like bundle creation, $GIT_DIR should be
strictly read-only. There is no reason for this application to need
to create temporary files, as the bundle can be streamed to stdout
(or optionally to a file supplied by the user on the command line).
> > + git-rev-list --objects $fullrevargs | cut -b-40 |
> > + git pack-objects --all-progress --stdout > "$pack" &&
>
> pack-objects can take rev-list arguments itself these days, using "--revs"
> and being piped the rev-list arguments.
Uh, actually it can't. I thought it could too. It doesn't.
It can only take a ref name or --not. I'm actually not sure why
we limited it like that, but we did... It may be a good idea to
change that restriction to not exist.
--
Shawn.
next prev parent reply other threads:[~2007-02-19 7:57 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-18 22:47 [PATCH] Add git-bundle: move objects and references by archive Mark Levedahl
2007-02-19 1:07 ` Johannes Schindelin
2007-02-19 1:50 ` Junio C Hamano
2007-02-19 2:02 ` Johannes Schindelin
2007-02-19 7:56 ` Shawn O. Pearce [this message]
2007-02-19 13:29 ` Mark Levedahl
2007-02-19 15:03 ` Johannes Schindelin
2007-02-19 1:49 ` Junio C Hamano
[not found] <Pine.LNX.4.63.0702220157130.22628@wbgn013.biozentrum.uni-wuerz burg.de>
2007-02-22 0:59 ` Johannes Schindelin
2007-02-22 3:28 ` Nicolas Pitre
2007-02-22 15:55 ` Johannes Schindelin
2007-02-22 16:14 ` Simon 'corecode' Schubert
2007-02-22 16:28 ` Nicolas Pitre
2007-02-22 16:37 ` Johannes Schindelin
2007-02-22 16:46 ` Simon 'corecode' Schubert
2007-02-22 17:09 ` Johannes Schindelin
2007-02-22 16:24 ` Nicolas Pitre
2007-02-22 17:12 ` Johannes Schindelin
2007-02-22 17:21 ` Nicolas Pitre
2007-02-22 6:56 ` Junio C Hamano
2007-02-22 7:08 ` Junio C Hamano
2007-02-22 16:20 ` Johannes Schindelin
2007-02-22 19:10 ` Junio C Hamano
2007-02-22 19:16 ` Johannes Schindelin
2007-02-22 20:05 ` Junio C Hamano
2007-02-22 20:25 ` Johannes Schindelin
2007-02-22 16:17 ` Johannes Schindelin
2007-02-23 2:32 ` Mark Levedahl
2007-02-23 4:39 ` Junio C Hamano
2007-02-22 9:31 ` Johannes Sixt
-- strict thread matches above, loose matches on Subject: below --
2007-02-17 18:41 [PATCH] Add git-unbundle - unpack objects and references for disconnected transfer Junio C Hamano
2007-02-18 17:27 ` [PATCH] Add git-bundle: move objects and references by archive Mark Levedahl
2007-02-18 22:47 ` Mark Levedahl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070219075654.GB30030@spearce.org \
--to=spearce@spearce$(echo .)org \
--cc=Johannes.Schindelin@gmx$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
--cc=mdl123@verizon$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox