From: Theodore Tso <tytso@mit•edu>
To: Junio C Hamano <junkio@cox•net>
Cc: "Shawn O. Pearce" <spearce@spearce•org>,
James Bowes <jbowes@dangerouslyinc•com>,
git@vger•kernel.org, Johannes.Schindelin@gmx•de
Subject: Re: [PATCH] Make gc a builtin.
Date: Wed, 14 Mar 2007 03:44:40 -0400 [thread overview]
Message-ID: <20070314074440.GC12710@thunk.org> (raw)
In-Reply-To: <7vodmwfg2c.fsf@assigned-by-dhcp.cox.net>
On Wed, Mar 14, 2007 at 12:19:07AM -0700, Junio C Hamano wrote:
> >> -test "true" != "$pack_refs" ||
> >> -git-pack-refs --prune &&
> >> -git-reflog expire --all &&
> >> -git-repack -a -d -l &&
> >> ...
>
> I do not necessarily think so. This is not even a performance
> critical part of the system, so if there _were_ no other
> constraints, I would rather keep scripts like this as scripts.
I agree with Junio; I think the scripts are much more readable and
easier to understand; In fact, it would be nice if the script were
preserved somewhere, perhaps as comments in the .c file.
- Ted
next prev parent reply other threads:[~2007-03-14 7:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-14 1:58 [PATCH] Make gc a builtin James Bowes
2007-03-14 6:07 ` Shawn O. Pearce
2007-03-14 7:19 ` Junio C Hamano
2007-03-14 7:44 ` Theodore Tso [this message]
2007-03-14 7:55 ` Santi Béjar
2007-03-14 9:29 ` Junio C Hamano
2007-03-14 10:45 ` Andy Parkins
2007-03-14 11:12 ` Junio C Hamano
2007-03-14 11:48 ` Andy Parkins
2007-03-14 12:19 ` Johannes Schindelin
-- strict thread matches above, loose matches on Subject: below --
2007-03-13 23:03 James Bowes
2007-03-14 1:05 ` Johannes Schindelin
2007-03-14 1:37 ` Brian Gernhardt
2007-03-11 22:06 [PATCH 0/2] " James Bowes
2007-03-11 22:06 ` [PATCH 2/2] " James Bowes
2007-03-11 22:48 ` Johannes Schindelin
2007-03-12 2:11 ` Junio C Hamano
2007-03-12 2:51 ` [PATCH] " James Bowes
2007-03-12 14:43 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070314074440.GC12710@thunk.org \
--to=tytso@mit$(echo .)edu \
--cc=Johannes.Schindelin@gmx$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
--cc=jbowes@dangerouslyinc$(echo .)com \
--cc=junkio@cox$(echo .)net \
--cc=spearce@spearce$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox