From: "Ismail Dönmez" <ismail@pardus•org.tr>
To: Junio C Hamano <junkio@cox•net>
Cc: git@vger•kernel.org, Jakub Narebski <jnareb@gmail•com>
Subject: Re: [PATCH] gitweb: use decode_utf8 directly
Date: Wed, 2 May 2007 00:48:53 +0300 [thread overview]
Message-ID: <200705020048.53853.ismail@pardus.org.tr> (raw)
In-Reply-To: <200705020044.47171.ismail@pardus.org.tr>
On Wednesday 02 May 2007 00:44:46 you wrote:
> On Wednesday 02 May 2007 00:39:34 you wrote:
> > Ismail Dönmez <ismail@pardus•org.tr> writes:
> > > Ok found out the reason. decode() tries to decode data that is already
> > > UTF-8 and borks.
> > >
> > > This is from Encode.pm :
> > >
> > > sub decode_utf8($;$) {
> > > my ( $str, $check ) = @_;
> > > return $str if is_utf8($str); <--- Checks if the $str is already
> > > UTF-8 if ($check) {
> > > return decode( "utf8", $str, $check ); <--- Else do what gitweb
> > > does [...]
> > >
> > > So my patch is indeed correct.
> >
> > Ok, I think that makes it an improvement from the current code,
> > so I'd apply.
> >
> > But at the same time I wonder why should the callers be feeding
> > an already decoded string to to_utf8(). It might be that some
> > callers needs fixing.
>
> FWIW it was passing my name "İsmail Dönmez" based on user info I guess.
I guess its line 1116:
if (check_export_ok("$projectroot/$path")) {
my $pr = {
path => $path,
owner => to_utf8($owner), <---- Here
};
My system is configured for UTF-8 so $owner will be UTF-8 but in some systems
it might not be so I don't think there is anything to fix here.
Regards,
ismail
next prev parent reply other threads:[~2007-05-01 21:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-24 14:05 [PATCH] gitweb: use decode_utf8 directly Ismail Dönmez
2007-04-27 8:55 ` Ismail Dönmez
2007-04-27 9:07 ` Junio C Hamano
2007-04-27 9:22 ` Ismail Dönmez
2007-04-27 19:29 ` Junio C Hamano
2007-05-01 21:12 ` Ismail Dönmez
2007-05-01 21:39 ` Junio C Hamano
2007-05-01 21:44 ` Ismail Dönmez
2007-05-01 21:48 ` Ismail Dönmez [this message]
2007-05-03 19:22 ` Ismail Dönmez
2007-05-03 19:26 ` Junio C Hamano
2007-06-01 13:45 ` Alexandre Julliard
2007-06-01 13:50 ` Ismail Dönmez
2007-06-01 16:51 ` Alexandre Julliard
2007-06-01 19:44 ` Junio C Hamano
2007-06-01 19:47 ` Ismail Dönmez
2007-06-01 20:00 ` Junio C Hamano
2007-06-01 20:08 ` Ismail Dönmez
2007-06-03 22:06 ` Junio C Hamano
2007-06-03 22:13 ` Ismail Dönmez
2007-06-02 8:22 ` Jakub Narebski
-- strict thread matches above, loose matches on Subject: below --
2007-06-01 16:13 Martin Koegler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200705020048.53853.ismail@pardus.org.tr \
--to=ismail@pardus$(echo .)org.tr \
--cc=git@vger$(echo .)kernel.org \
--cc=jnareb@gmail$(echo .)com \
--cc=junkio@cox$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox