From: "Shawn O. Pearce" <spearce@spearce•org>
To: Nicolas Pitre <nico@cam•org>
Cc: Dana How <danahow@gmail•com>, Junio C Hamano <junkio@cox•net>,
Git Mailing List <git@vger•kernel.org>
Subject: Re: [PATCH] Create pack-write.c for common pack writing code
Date: Wed, 2 May 2007 12:31:22 -0400 [thread overview]
Message-ID: <20070502163122.GL5942@spearce.org> (raw)
In-Reply-To: <alpine.LFD.0.98.0705021226010.6574@xanadu.home>
Nicolas Pitre <nico@cam•org> wrote:
> BTW I think the common function should _not_ close the file descriptor
> it is being handed. It is more flexible to let the caller close the
> file, or possibly do whatever other operations like fchmod().
I didn't mention it, but I agree, and fixed it in Dana's patch.
--
Shawn.
next prev parent reply other threads:[~2007-05-02 16:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-01 18:26 [PATCH] Create pack-write.c for common pack writing code Dana How
2007-05-02 16:16 ` Shawn O. Pearce
2007-05-02 16:29 ` Nicolas Pitre
2007-05-02 16:31 ` Shawn O. Pearce [this message]
2007-05-02 17:25 ` Dana How
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070502163122.GL5942@spearce.org \
--to=spearce@spearce$(echo .)org \
--cc=danahow@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=junkio@cox$(echo .)net \
--cc=nico@cam$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox