From: Martin Waitz <tali@admingilde•org>
To: "Shawn O. Pearce" <spearce@spearce•org>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx•de>,
Dana How <danahow@gmail•com>, Junio C Hamano <junkio@cox•net>,
Git Mailing List <git@vger•kernel.org>
Subject: Re: [PATCH v3] Support ent:relative_path
Date: Sat, 5 May 2007 21:32:14 +0200 [thread overview]
Message-ID: <20070505193214.GD30511@admingilde.org> (raw)
In-Reply-To: <20070505033039.GD16538@spearce.org>
[-- Attachment #1: Type: text/plain, Size: 1351 bytes --]
On Fri, May 04, 2007 at 11:30:39PM -0400, Shawn O. Pearce wrote:
> Johannes Schindelin <Johannes.Schindelin@gmx•de> wrote:
> > On Fri, 4 May 2007, Dana How wrote:
> >
> > > Most commands accept relative paths, but this is
> > > not true of arguments in ent:path format. This
> > > patch makes all of the following git-show commands
> > > work in the git source tree (not just the first):
> > > % cd xdiff
> > > % git-show v1.5.2-rc0:xdiff/xemit.h
> > > % git-show v1.5.2-rc0:./xemit.h
> > > % git-show v1.5.2-rc0:../sha1_name.c
> >
> > ACK.
>
> Double ACK. I'm in complete agreement with every point Dscho has
> made in this thread, even if I haven't quoted it. ;-)
>
> I *really* do not want to see "<tree-ish>:<path>" to mean include
> the current prefix, *especially* when a bare repository is involved.
we could also introduce "<tree-ish>/<path>" for absolute path entries.
This would make a lot of sense for submodules:
git show "<tree-ish>/path/to/submodule/path/inside/submodule
with only : it would not look that nice ;-)
OK, we could simply say that submodules are special and that you
don't have to use : to separate a commit (the submodule entry) from
the path inside.
aside from that I would also really like to have both absolute and
relative ways to name objects.
--
Martin Waitz
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2007-05-05 19:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-05 0:47 [PATCH v3] Support ent:relative_path Dana How
2007-05-05 1:11 ` Jakub Narebski
2007-05-05 1:29 ` Johannes Schindelin
2007-05-05 3:30 ` Shawn O. Pearce
2007-05-05 19:32 ` Martin Waitz [this message]
2007-05-05 20:17 ` Junio C Hamano
2007-05-05 21:18 ` Martin Waitz
2007-05-06 0:59 ` Johannes Schindelin
2007-05-06 18:52 ` Martin Waitz
2007-05-06 23:09 ` Johannes Schindelin
2007-05-05 20:37 ` Alex Riesen
2007-05-05 3:38 ` Junio C Hamano
2007-05-05 6:46 ` Dana How
2007-05-05 8:03 ` Alex Riesen
2007-05-05 14:39 ` Johannes Schindelin
2007-05-06 6:38 ` Junio C Hamano
2007-05-06 15:14 ` Johannes Schindelin
2007-05-06 17:35 ` Junio C Hamano
2007-05-06 23:12 ` Johannes Schindelin
2007-05-07 0:18 ` Junio C Hamano
2007-05-07 0:37 ` Dana How
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070505193214.GD30511@admingilde.org \
--to=tali@admingilde$(echo .)org \
--cc=Johannes.Schindelin@gmx$(echo .)de \
--cc=danahow@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=junkio@cox$(echo .)net \
--cc=spearce@spearce$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox