From: Andy Parkins <andyparkins@gmail•com>
To: git@vger•kernel.org
Cc: Junio C Hamano <junkio@cox•net>
Subject: Re: [PATCH] Fix crlf attribute handling to match documentation
Date: Sat, 19 May 2007 10:58:29 +0100 [thread overview]
Message-ID: <200705191058.32473.andyparkins@gmail.com> (raw)
In-Reply-To: <7v646p4r50.fsf@assigned-by-dhcp.cox.net>
On Saturday 2007, May 19, Junio C Hamano wrote:
> The check you modified in the first hunk is not the above '<='
> comparison but is this:
I was talking about the second hunk there though, which I mentioned
with "...skipped in crlf_to_worktree()...". In which case the
description matches.
> (action == CRLF_GUESS && !auto_crlf)
>
> and "core.autocrlf = input" makes "auto_crlf = -1", so when
> action is not GUESS, or even when action is GUESS, if the config
> is set to "input", the if() statement you patched in the first
> hunk should not trigger. The above description is different from
> what the code was doing.
As I say, the description was for the second hunk.
The fault was my last paragraph, "Similarly for crlf_to_worktree(), if
core.autocrlf is false, no", which should have said "Similarly for
crlf_to_git()". Sorry.
With that small change I think my description was correct. However, it
obviously wasn't clear - apologies.
Andy
--
Dr Andy Parkins, M Eng (hons), MIET
andyparkins@gmail•com
prev parent reply other threads:[~2007-05-19 9:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-18 12:33 [PATCH] Fix crlf attribute handling to match documentation Andy Parkins
2007-05-18 18:28 ` Junio C Hamano
2007-05-19 0:02 ` Junio C Hamano
2007-05-19 9:58 ` Andy Parkins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200705191058.32473.andyparkins@gmail.com \
--to=andyparkins@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=junkio@cox$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox