public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Martin Waitz <tali@admingilde•org>
To: Junio C Hamano <junkio@cox•net>
Cc: Alex Riesen <raa.lkml@gmail•com>,
	git@vger•kernel.org, Sven Verdoolaege <skimo@kotnet•org>
Subject: Re: [PATCH] Add ability to specify environment extension to run_command
Date: Tue, 22 May 2007 08:03:02 +0200	[thread overview]
Message-ID: <20070522060302.GH5412@admingilde.org> (raw)
In-Reply-To: <7v7ir1dbl9.fsf@assigned-by-dhcp.cox.net>

[-- Attachment #1: Type: text/plain, Size: 454 bytes --]

hoi :)

On Mon, May 21, 2007 at 04:02:42PM -0700, Junio C Hamano wrote:
> I had a feeling that some callers needed to be able to unsetenv
> some.  How would this patch help them, or are they outside of
> the scope?

At first I had the same objection but the putenv documentation
told me that at least in glibc you can unsetenv by providing
the variable name without a "=".

But perhaps we should check for other systems?

-- 
Martin Waitz

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

  reply	other threads:[~2007-05-22  6:03 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-20 15:39 [PATCH] allow commands to be executed in submodules Martin Waitz
2007-05-20 18:14 ` Alex Riesen
2007-05-20 18:25   ` Junio C Hamano
2007-05-20 20:48     ` Martin Waitz
2007-05-20 20:59       ` Alex Riesen
2007-05-20 21:08         ` Martin Waitz
     [not found]   ` <20070521090339.GH942MdfPADPa@greensroom.kotnet.org>
2007-05-21 22:48     ` [PATCH] Add ability to specify environment extension to run_command Alex Riesen
2007-05-21 23:02       ` Junio C Hamano
2007-05-22  6:03         ` Martin Waitz [this message]
2007-05-22  6:33           ` Junio C Hamano
2007-05-22  6:38             ` Shawn O. Pearce
2007-05-22  6:54               ` Sven Verdoolaege
2007-05-22 21:51             ` Alex Riesen
2007-05-22 21:47         ` Alex Riesen
2007-05-22 21:48           ` [PATCH] Add run_command_v_opt_cd: chdir into a directory before exec Alex Riesen
2007-05-22 21:48             ` [PATCH] Add ability to specify environment extension to run_command Alex Riesen
2007-05-22 21:49               ` [PATCH] Allow environment variables to be unset in the processes started by run_command Alex Riesen
2007-05-22 22:19           ` [PATCH] Add ability to specify environment extension to run_command Junio C Hamano
2007-05-22 23:14             ` Alex Riesen
2007-05-23 20:21               ` [PATCH] Allow environment variables to be unset in the processes started by run_command Alex Riesen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070522060302.GH5412@admingilde.org \
    --to=tali@admingilde$(echo .)org \
    --cc=git@vger$(echo .)kernel.org \
    --cc=junkio@cox$(echo .)net \
    --cc=raa.lkml@gmail$(echo .)com \
    --cc=skimo@kotnet$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox