From: "Shawn O. Pearce" <spearce@spearce•org>
To: Dana How <danahow@gmail•com>
Cc: Junio C Hamano <junkio@cox•net>, Git Mailing List <git@vger•kernel.org>
Subject: Re: [PATCH] Split packs from git-repack should have descending timestamps
Date: Thu, 24 May 2007 20:46:10 -0400 [thread overview]
Message-ID: <20070525004610.GP28023@spearce.org> (raw)
In-Reply-To: <465612CE.4080605@gmail.com>
Dana How <danahow@gmail•com> wrote:
>
> If git-repack produces multiple split packs because
> --max-pack-size was in effect, the first pack written
> should have the latest timestamp because:
> (1) sha1_file.c:rearrange_packed_git() puts more recent
> pack files at the beginning of the search list; and
> (2) the most recent objects are written out first
> while packing.
>
> This is based on next rather than master to avoid merge
> conflicts with changes already in git-repack.sh due to
> the --max-pack-size patchset.
Ack. Given our mtime based sorting routine, even without your
recent patch to improve it, I think we definately want this type
of behavior built into git-repack.sh. Good follow-on to your
--max-pack-size series.
--
Shawn.
next prev parent reply other threads:[~2007-05-25 0:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-24 22:33 [PATCH] Split packs from git-repack should have descending timestamps Dana How
2007-05-25 0:46 ` Shawn O. Pearce [this message]
2007-05-25 1:04 ` Junio C Hamano
2007-05-25 2:33 ` Dana How
2007-05-25 3:18 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070525004610.GP28023@spearce.org \
--to=spearce@spearce$(echo .)org \
--cc=danahow@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=junkio@cox$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox