From: "Shawn O. Pearce" <spearce@spearce•org>
To: Junio C Hamano <junkio@cox•net>
Cc: git@vger•kernel.org, Alex Riesen <raa.lkml@gmail•com>,
Johannes Schindelin <Johannes.Schindelin@gmx•de>
Subject: Re: [PATCH] Introduce git version --list-features for porcelain use
Date: Thu, 31 May 2007 23:09:59 -0400 [thread overview]
Message-ID: <20070601030959.GY7044@spearce.org> (raw)
In-Reply-To: <7vk5uo1rpr.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano <junkio@cox•net> wrote:
> "Shawn O. Pearce" <spearce@spearce•org> writes:
>
> > As a porcelain author I'm finding it difficult to keep track of
> > what features I can use in git-gui. Newer versions of Git have
> > newer capabilities but they don't always immediately get newer
> > version numbers that I can easily test for.
> >
> > This is a simple plumbing option that lets a porcelain ask the
> > plumbing for its capabilities, at which point the porcelain can
> > work around anything missing, or recommend to the user that they
> > upgrade their plumbing layer.
> >
> > Signed-off-by: Shawn O. Pearce <spearce@spearce•org>
> > ---
> >
> > Johannes Schindelin <Johannes.Schindelin@gmx•de> wrote:
> > >
> > > On Wed, 30 May 2007, Alex Riesen wrote:
> > >
> > > > git-version --features?
> > >
> > > Melikes.
> >
> > Good?
>
> Hmmm. I am not sure if you want list-features in the features
> list -- how are you going to test for it?
Yes, its a recursive definition. But its also a feature that won't
ever be removed; if list-features is here then the list-features
feature is also here. Makes the test in t0000 a lot easier, and
its not a huge deal to say "yes, the feature that i implement is
here too". ;-)
> Also I still do not understand why you want redirect-stderr.
> Are you writing for a shell-less environment?
The redirect-stderr thing grew out of the MinGW port camp.
Apparently they cannot use (or its hard to use) an important little
tool called `cat` over there.
Why cat? Tcl is so horribly broken that to get data for both stdout
and stderr through a pipe I have to do something sick like:
git fetch 2>&1 | cat
because in Tcl its actually:
set rdr [open "| git fetch |& cat" r]
The |& means 2>&1| in normal shell. But that means I have to have
a process after it to receive the data. Normally that's cat.
But MinGW doesn't have cat. (Nor do they have dog, but neither
does Linux...). So I need a way to redirect output.
Dscho's patch to git.c to give me `git --redirect-stderr` is quite
simple, and makes my life in git-gui easier. I can just require
that to use git-gui on MinGW you must have the 'redirect-stderr'
feature supported in your plumbing layer. On non-MinGW systems I
can fallback to "&| cat" if its not supported.
--
Shawn.
next prev parent reply other threads:[~2007-06-01 3:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-30 4:31 [PATCH] Introduce git-supported-features for porcelain use Shawn O. Pearce
2007-05-30 12:04 ` Alex Riesen
2007-05-30 12:34 ` Johannes Schindelin
2007-05-31 0:20 ` [PATCH] Introduce git version --list-features " Shawn O. Pearce
2007-05-31 0:25 ` Johannes Schindelin
2007-05-31 6:50 ` Alex Riesen
2007-05-31 13:30 ` Shawn O. Pearce
2007-05-31 23:46 ` Junio C Hamano
2007-06-01 3:09 ` Shawn O. Pearce [this message]
2007-06-01 3:57 ` Junio C Hamano
2007-06-01 4:14 ` Shawn O. Pearce
2007-06-01 7:13 ` Johannes Sixt
-- strict thread matches above, loose matches on Subject: below --
2007-06-21 4:59 Shawn O. Pearce
2007-06-21 5:47 ` Junio C Hamano
2007-06-21 6:10 ` Shawn O. Pearce
2007-06-21 7:02 ` Junio C Hamano
2007-06-21 11:58 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070601030959.GY7044@spearce.org \
--to=spearce@spearce$(echo .)org \
--cc=Johannes.Schindelin@gmx$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
--cc=junkio@cox$(echo .)net \
--cc=raa.lkml@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox