Subject: Re: [PATCH] gitweb: use decode_utf8 directly

From: Ismail Dönmez <[email-masked]>
Date: Fri, 1 Jun 2007 22:47:52 +0300

On Friday 01 June 2007 22:44:36 Junio C Hamano wrote:
> Alexandre Julliard <[email-masked]> writes:
> > Sorry for the late nack, but it turns out that this patch breaks diff
> > output on the Wine server for files that are not utf-8.
> >
> > The cause is apparently that decode_utf8() returns undef for invalid
> > sequences instead of substituting a replacement char like
> > decode("utf8") does.
>
> Thanks for noticing.  Will revert.

Why are reverting a correct bugfix? :( He's at most using outdated software. 
*sigh*

/ismail

-- 
Perfect is the enemy of good