Subject: Re: [PATCH (REVISED)] Add core.editor configuration variable

From: Andy Parkins <[email-masked]>
Date: Thu, 19 Jul 2007 08:48:51 +0100

On Thursday 2007 July 19, Adam Roben wrote:

>    Well, it turns out we already do launch an editor in other places,
> namely "git am -i" and "git send-email --compose". So, this patch takes
> care of those cases as well.

Perhaps I'm being overly pedantic, but it seems odd to put options that are 
relevant only to porcelain under the "core" section.

core.pager is in the same category - but that's already in.

Would porcelain.editor be a better name for this variable?

Andy

-- 
Dr Andy Parkins, M Eng (hons), MIET
[email-masked]