From: "Shawn O. Pearce" <spearce@spearce•org>
To: Luke Lu <git@vicaya•com>
Cc: git@vger•kernel.org, pasky@suse•cz
Subject: Re: [PATCH] gitweb: speed up project listing on large work trees by limiting find depth
Date: Wed, 17 Oct 2007 01:25:14 -0400 [thread overview]
Message-ID: <20071017052514.GW13801@spearce.org> (raw)
In-Reply-To: <562B5254-2BE7-43DF-AB62-499458E360CC@vicaya.com>
Luke Lu <git@vicaya•com> wrote:
> OK, let me try again :) I was using no_chdir => 1 to shorten the tr,
> as well as saving a syscall. However the code is expecting $_ to be
> relative elsewhere (line 1524) to check for the toplevel, so the
> check failed for the toplevel because of no_chdir, which caused
> substr to work on the toplevel, which is $pfxlen long. Note $pfxlen +
> 1 passes the end of the toplevel path, hence the errors, though the
> program still worked correctly, as $subdir is undefined in this case,
> which would by pass the rest of the code, which is logically correct.
> It'll probably crash, if it's written in C :)
>
> So, I got rid of no_chdir => 1 in the new patch and uses
> $File::Find::name directly, as otherwise I'd have to come up with a
> messier regex for checking toplevel at line 1524.
*light dawns*. Thank you for the explanation.
--
Shawn.
prev parent reply other threads:[~2007-10-17 5:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-17 3:45 [PATCH] gitweb: speed up project listing on large work trees by limiting find depth Luke Lu
2007-10-17 4:00 ` Shawn O. Pearce
2007-10-17 4:19 ` Luke Lu
2007-10-17 4:27 ` Shawn O. Pearce
[not found] ` <562B5254-2BE7-43DF-AB62-499458E360CC@vicaya.com>
2007-10-17 5:25 ` Shawn O. Pearce [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071017052514.GW13801@spearce.org \
--to=spearce@spearce$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
--cc=git@vicaya$(echo .)com \
--cc=pasky@suse$(echo .)cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox