From: Eric Wong <normalperson@yhbt•net>
To: Anton Korobeynikov <asl@math•spbu.ru>
Cc: git@vger•kernel.org
Subject: Re: Possible bug: git-svn leaves broken tree in case of error
Date: Wed, 31 Oct 2007 00:55:24 -0700 [thread overview]
Message-ID: <20071031075524.GB7798@muzzle> (raw)
In-Reply-To: <1193729426.30755.32.camel@asl.dorms.spbu.ru>
Anton Korobeynikov <asl@math•spbu.ru> wrote:
> Hello, Everyone.
>
> I noticed this bug several times. Consider the following conditions are
> met:
> - We're syncing from svn using git-svn :)
> - We have authors file provided
> - We have a changeset with author unlisted in the authors file.
>
> git-svn dies due to the following code:
> sub check_author {
> my ($author) = @_;
> if (!defined $author || length $author == 0) {
> $author = '(no author)';
> }
> if (defined $::_authors && ! defined $::users{$author}) {
> die "Author: $author not defined in $::_authors file\n";
> }
> $author;
> }
>
> Unfortunately it leaves repository in some middle state: git-svn itself
> thinks, that it synced with everything, but git itself doesn't "see" any
> changesets anymore. I found no way to repair tree after such situation,
> so I had to repull from scratch.
>
> I found myself, that this should be warning (and fix in this case is
> trivial), not error (maybe some commandline switch to control behaviour,
> etc). It can be even error, but breaking tree is definitely bug in this
> case.
You should be able to change the numbers in *-maxRev back to
an old revision in .git/svn/.metadata. Does that fix things for you
so you can resume synching again?
I'll have to investigate the die()-ing of check_authors since
that should cause git-svn to quit before the maxRev numbers
get incremented.
--
Eric Wong
next prev parent reply other threads:[~2007-10-31 7:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-30 7:30 Possible bug: git-svn leaves broken tree in case of error Anton Korobeynikov
2007-10-31 7:55 ` Eric Wong [this message]
2007-10-31 8:42 ` Eric Wong
2007-10-31 10:23 ` Karl Hasselström
[not found] ` <20071031084257.GA2911.SS5073SS@mayonaise>
2007-10-31 14:04 ` Anton Korobeynikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071031075524.GB7798@muzzle \
--to=normalperson@yhbt$(echo .)net \
--cc=asl@math$(echo .)spbu.ru \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox