From: Pierre Habouzit <madcoder@debian•org>
To: Johannes Sixt <j.sixt@viscovery•net>
Cc: "Johannes Schindelin" <Johannes.Schindelin@gmx•de>,
"Björn Steinbrink" <B.Steinbrink@gmx•de>,
"Kristian Høgsberg" <krh@redhat•com>,
"Junio C Hamano" <gitster@pobox•com>,
git@vger•kernel.org
Subject: Re: [PATCH 4/4] Implement git commit and status as a builtin commands.
Date: Tue, 06 Nov 2007 10:26:48 +0100 [thread overview]
Message-ID: <20071106092648.GG4435@artemis.corp> (raw)
In-Reply-To: <4730314A.9010403@viscovery.net>
[-- Attachment #1: Type: text/plain, Size: 1418 bytes --]
On Tue, Nov 06, 2007 at 09:18:02AM +0000, Johannes Sixt wrote:
> Pierre Habouzit schrieb:
> >Btw, I'm starting to work slowly on the diff_opt_parse conversion to the
> >macro we discussed, and the need for new option parsing callbacks
> >arised, and I've created a:
> > parse_opt_mask_{or,and,xor} commands that you declare this way:
> > OPT_MASK_OR('a', "all", &mode, "...", MASK_ALL),
> > OPT_MASK_OR('i', "interactive", &mode, "...", MASK_INTERACTIVE),
> > ...
> >And if you chose MASK_ALL/INTERACTIVE/.. to be single bits,
> > if (!!all + !!interactive ... > 1)
> >becomes[0]:
> > if (mode & (mode - 1)) {
> > }
>
> This goes too far, IMHO. That's unnecessary cleverness/microoptimization
> at the expense of readability.
The reason why I did that is not to be able to do mode & (mode - 1).
Have a look at diff.c, imagine the insane amount of intermediate
variables we would need, and now understand why I introduced that :)
I'm not sure it's useful for git-commit, I was mentioning it just in case.
Note: the fact that an OPT_BOOLEAN when you repeat it increments the
value isn't always a good thing, and is the reason why you need
the (quite ugly) double bangs.
--
·O· Pierre Habouzit
··O madcoder@debian•org
OOO http://www.madism.org
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2007-11-06 9:27 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-02 15:33 [PATCH 1/4] Add testcase for ammending and fixing author in git commit Kristian Høgsberg
2007-11-02 15:33 ` [PATCH 2/4] Remove unecessary hard-coding of EDITOR=':' VISUAL=':' in some test suites Kristian Høgsberg
2007-11-02 15:33 ` [PATCH 3/4] Export launch_editor() and make it accept ':' as a no-op editor Kristian Høgsberg
2007-11-02 15:33 ` [PATCH 4/4] Implement git commit and status as a builtin commands Kristian Høgsberg
2007-11-03 13:56 ` Johannes Schindelin
2007-11-08 16:01 ` Kristian Høgsberg
2007-11-03 15:06 ` Björn Steinbrink
2007-11-05 18:57 ` Kristian Høgsberg
2007-11-05 19:23 ` Björn Steinbrink
2007-11-05 23:18 ` Johannes Schindelin
2007-11-06 6:59 ` Björn Steinbrink
2007-11-06 16:46 ` Kristian Høgsberg
2007-11-06 17:08 ` Björn Steinbrink
2007-11-06 9:12 ` Pierre Habouzit
2007-11-06 9:18 ` Johannes Sixt
2007-11-06 9:26 ` Pierre Habouzit [this message]
2007-11-06 9:47 ` Andreas Ericsson
2007-11-06 16:42 ` Kristian Høgsberg
2007-11-02 15:46 ` [PATCH 3/4] Export launch_editor() and make it accept ':' as a no-op editor Andreas Ericsson
2007-11-02 16:16 ` Kristian Høgsberg
2007-11-02 20:09 ` [PATCH 2/4] Remove unecessary hard-coding of EDITOR=':' VISUAL=':' in some test suites Junio C Hamano
2007-11-02 20:07 ` [PATCH 1/4] Add testcase for ammending and fixing author in git commit Junio C Hamano
2007-11-02 21:13 ` Kristian Høgsberg
2007-11-02 22:33 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071106092648.GG4435@artemis.corp \
--to=madcoder@debian$(echo .)org \
--cc=B.Steinbrink@gmx$(echo .)de \
--cc=Johannes.Schindelin@gmx$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=j.sixt@viscovery$(echo .)net \
--cc=krh@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox