Subject: Re: [PATCH] tests: git push mirror mode tests V2

From: Andy Whitcroft <[email-masked]>
Date: Mon, 12 Nov 2007 15:25:41 +0000

On Fri, Nov 09, 2007 at 12:05:43PM -0800, Junio C Hamano wrote:
> Andy Whitcroft <[email-masked]> writes:
> 
> > +test_expect_success 'push mirror does not create new branches' '
> > +
> > +	mk_repo_pair &&
> > +	(
> > +		cd master &&
> > +		echo one >foo && git add foo && git commit -m one &&
> > +		git push --mirror up
> > +	) &&
> > +	master_master=$(cd master && git show-ref -s --verify refs/heads/master) &&
> > +	mirror_master=$(cd mirror && git show-ref -s --verify refs/heads/master) &&
> > +	test "$master_master" = "$mirror_master"
> > +
> > +'
> 
> I am quite puzzled by this and many other "does not" in the test
> description.  The --mirror option is advertised as
> 
>  - newly created will be pushed;
>  - locally updated will be force pushed;
>  - locally deleted will be removed.
> 
> which makes sense as we do want these things to happen for
> "mirrors".  Indeed the above updates master branch at the master
> repository and makes sure that change is propagated to the
> mirror repository.  The description should read "push mirror
> creates new branches" shouldn't it?

Indeed, I think the problem was a miss-understanding of the example I
copied from.  I think partly I thought that the message was only
displayed on failure.  Which is firstly demonstrably false, and secondly
I am not consistent in applying that false knowledge.

If these are not already fixed up in pu I will check and sort them out.

-apw