public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Charles Bailey <charles@hashpling•org>
To: Johannes Schindelin <Johannes.Schindelin@gmx•de>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] Fix the MacOS X compile of gitk by pinching po2msg.sh from git-gui
Date: Wed, 9 Jan 2008 13:52:49 +0000	[thread overview]
Message-ID: <20080109135249.GA12869@hashpling.org> (raw)
In-Reply-To: <alpine.LSU.1.00.0801091339390.31053@racer.site>

On Wed, Jan 09, 2008 at 01:40:46PM +0000, Johannes Schindelin wrote:
> Hi,
> 
> On Wed, 9 Jan 2008, Charles Bailey wrote:
> 
> > --- snip ---
> 
> Since gitk and git-gui are separate projects (pulled at irregular 
> intervals into git.git), your patch looks sane, but would be better done 
> as a patch against gitk.git.
> 
> Ciao,
> Dscho

I'm sorry, I think I knew this once, but had forgotten.  Of course, as
a patch against gitk, I think it gets quite verbose as the patch
includes a full copy of the po2msg.sh script.

Is there a simple way to generate a gitk.git patch from a git.git
clone, or do I need to clone a gitk repository from somewhere?

Perhaps I could just flag this as a reasonably important MacOS X
1.5.4-rc issue until I can sort out a more suitable patch?

Thanks,

Charles.

  reply	other threads:[~2008-01-09 13:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-09 13:29 [PATCH] Fix the MacOS X compile of gitk by pinching po2msg.sh from git-gui Charles Bailey
2008-01-09 13:40 ` Johannes Schindelin
2008-01-09 13:52   ` Charles Bailey [this message]
2008-01-09 14:06     ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080109135249.GA12869@hashpling.org \
    --to=charles@hashpling$(echo .)org \
    --cc=Johannes.Schindelin@gmx$(echo .)de \
    --cc=git@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox