From: Pierre Habouzit <madcoder@debian•org>
To: Junio C Hamano <gitster@pobox•com>
Cc: Git ML <git@vger•kernel.org>
Subject: Re: [bug] generic issue with git_config handlers
Date: Thu, 31 Jan 2008 11:10:37 +0100 [thread overview]
Message-ID: <20080131101037.GG24403@artemis.madism.org> (raw)
In-Reply-To: <7v1w7ye48j.fsf@gitster.siamese.dyndns.org>
[-- Attachment #1: Type: text/plain, Size: 895 bytes --]
On Thu, Jan 31, 2008 at 09:25:32AM +0000, Junio C Hamano wrote:
> Pierre Habouzit <madcoder@debian•org> writes:
>
> > One of my co-workers stumbled upon a misfeature of the git config
> > parser. The following syntax is allowed:
> >
> > [section]
> > foo
>
> Yeah, that is how "truth" value of boolean is spelled.
>
> > [user]
> > name
>
> That's very unfortunate. Whatever is expecting string value
> should check for NULL. Fix should probably be easy enough for
> any git-hacker-wannabe to tackle ;-)
I think so too, though my count is something like 40 functions to
investigate (the 40 handlers) and where it recurses into ;) Too much
work for the time I have right now.
--
·O· Pierre Habouzit
··O madcoder@debian•org
OOO http://www.madism.org
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2008-01-31 10:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-31 9:16 [bug] generic issue with git_config handlers Pierre Habouzit
2008-01-31 9:25 ` Junio C Hamano
2008-01-31 10:10 ` Pierre Habouzit [this message]
2008-02-04 6:27 ` Christian Couder
2008-02-04 17:01 ` Johannes Sixt
2008-02-04 23:13 ` Christian Couder
2008-02-05 0:03 ` Junio C Hamano
2008-02-07 5:45 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080131101037.GG24403@artemis.madism.org \
--to=madcoder@debian$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox