From: Jakub Narebski <jnareb@gmail•com>
To: Sam Vilain <sam@vilain•net>
Cc: Juan Jose Comellas <juanjo@comellas•org>, git@vger•kernel.org
Subject: Re: FastCGI support in gitweb
Date: Tue, 4 Mar 2008 01:19:21 +0100 [thread overview]
Message-ID: <200803040119.22240.jnareb@gmail.com> (raw)
In-Reply-To: <47CBEED2.30808@vilain.net>
On Mon, 3 Mar 2008, Sam Vilain wrote:
> Jakub Narebski wrote:
>> First, as far as I understand it, the patch made gitweb had to be used
>> with FastCGI server. It has no comments in code, and if I remember
>> correctly the commit message was also fairly nonexistent. It mixes
>> FastCGI changes with site-wide changes. It wrapped the whole file in
>> "until last request" loop instead of wrapping dispatch only.
>>
>> Also I am not sure if gitweb doesn't rely on variables being correctly
>> set which they are not in FastCGI mode.
>>
>> But most important part: it was never resend (IIRC it was send when
>> gitweb development was in separate repository)
>>
>>
>> I have attached the FastCGI patch and CC-ed the author.
>
> Thanks. I didn't submit this because I couldn't fix the bugs in it.
> Glad you found it. I had to make many changes in a similar vein with a
> current gitweb version; did it work for you in its current form?
I couldn't test it with FastCGI server, as I use Apache2, and all
FastCGI modules for Apache are third part modules. Besides, it doesn't
make much sense to use generic FastCGI for Perl, when there is mod_perl
module.
For me for the FastCGI change to be made into mainline it would have
to have the following properties:
* it should be able to run as both CGI module, and under mod_perl
module (in legacy mode with ModPerl::Registry) without trouble
* is should be able to run even if CGI::Fast or FCGI Perl modules
are not installed in the system
* the loop over requests should try to be minimal, and not encompass
whole file
The last condition would probably require to separate option parsing
and validation into separate subroutine.
> You can get it to run externally using FCGI_SOCKET=:3000 (eg, to listen
> on FastCGI TCP port 3000)
Could you elaborate on this?
P.S. It would be good to have examples for web servers other than
Apache2 how to configure them to run gitweb: perhaps lighthttpd, Cheetah,
maybe IIS...
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2008-03-04 0:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-01 21:34 FastCGI support in gitweb Juan Jose Comellas
2008-03-01 21:50 ` Jakub Narebski
2008-03-03 12:28 ` Sam Vilain
2008-03-04 0:19 ` Jakub Narebski [this message]
2008-03-04 3:59 ` John Goerzen
2008-03-04 10:11 ` Jakub Narebski
2008-03-04 14:48 ` John Goerzen
2008-03-04 17:22 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200803040119.22240.jnareb@gmail.com \
--to=jnareb@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=juanjo@comellas$(echo .)org \
--cc=sam@vilain$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox