From: "Shawn O. Pearce" <spearce@spearce•org>
To: Johannes Sixt <j.sixt@viscovery•net>
Cc: Nicolas Pitre <nico@cam•org>, Junio C Hamano <gitster@pobox•com>,
git@vger•kernel.org, Daniel Barkalow <barkalow@iabervon•org>
Subject: Re: [PATCH 1/3] git-pack-objects: Automatically pack annotated tags if object was packed
Date: Wed, 5 Mar 2008 01:32:43 -0500 [thread overview]
Message-ID: <20080305063243.GG8410@spearce.org> (raw)
In-Reply-To: <47CCF9DA.4050304@viscovery.net>
Johannes Sixt <j.sixt@viscovery•net> wrote:
> Shawn O. Pearce schrieb:
> > Nicolas Pitre <nico@cam•org> wrote:
> >> On Mon, 3 Mar 2008, Shawn O. Pearce wrote:
> >>
> >>> The new option "--auto-follow-tags" allows the caller to request that
> >>> any annotated tag be included into the packfile if the object the tag
> >>> references was also included as part of the packfile.
> >> Wouldn't "auto-include-tag" a better name for this option?
> >
> > Ooooh. Indeed it would!
> >
> > I shall respin this series based around this better name.
>
> More bikeshedding: Why are you calling it "auto-"? If I tell the program
> to "--include-tags", I expect it to happen automatically.
Because its more automatic than manually including tags?
I don't know.
Junio, if you haven't already merged this topic into someplace that
I can't rewrite the series for a _3rd_ time, I might be willing to
respin it without the "auto-" prefix. We are unlikely to ever have
a reason to support "--manually-include-tags". Stone tablet based
computing stopped being fun back in the '50s.
--
Shawn.
next prev parent reply other threads:[~2008-03-05 6:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-04 2:36 [PATCH 1/3] git-pack-objects: Automatically pack annotated tags if object was packed Shawn O. Pearce
2008-03-04 2:45 ` Nicolas Pitre
2008-03-04 3:06 ` Shawn O. Pearce
2008-03-04 7:27 ` Johannes Sixt
2008-03-05 6:32 ` Shawn O. Pearce [this message]
2008-03-04 2:49 ` Daniel Barkalow
2008-03-04 3:06 ` Shawn O. Pearce
2008-03-04 3:11 ` Daniel Barkalow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080305063243.GG8410@spearce.org \
--to=spearce@spearce$(echo .)org \
--cc=barkalow@iabervon$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=j.sixt@viscovery$(echo .)net \
--cc=nico@cam$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox