From: Robin Rosenberg <robin.rosenberg@dewire•com>
To: Junio C Hamano <gitster@pobox•com>
Cc: Robin Rosenberg <robin.rosenberg.lists@dewire•com>,
Johannes Schindelin <Johannes.Schindelin@gmx•de>,
Johannes Sixt <j.sixt@viscovery•net>,
Shawn Bohrer <shawn.bohrer@gmail•com>,
git@vger•kernel.org
Subject: Re: [PATCH] More test cases for sanitized path names
Date: Fri, 7 Mar 2008 16:24:34 +0100 [thread overview]
Message-ID: <200803071624.35369.robin.rosenberg@dewire.com> (raw)
In-Reply-To: <7vwsof2b8l.fsf@gitster.siamese.dyndns.org>
Den Friday 07 March 2008 09.23.54 skrev Junio C Hamano:
> Robin Rosenberg <robin.rosenberg.lists@dewire•com> writes:
> > Verify a few more commands and pathname variants.
> >
> > Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire•com>
> > ---
> > t/t7010-setup.sh | 39 +++++++++++++++++++++++++++++++++++++++
> > 1 files changed, 39 insertions(+), 0 deletions(-)
> >
> > These are a few testcases from my earlier attempt at this. The
> > log and commit cases succeeded with Junios version, but not
> > blame and some of the nastier versions for git add (same
> > principle for all commands, just that I use add as an example)
>
> I am very sorry about replying to an ancient topic, but I think I misread
> your patch.
>
> > +test_expect_failure 'add a directory outside the work tree' '
> > + d1="$(cd .. ; pwd)" &&
> > + git add "$d1"
> > + echo $?
> > +'
>
> What I think I misunderstood was that you _wanted_ this (after removing
> the "echo", which was a mistake, which we already talked about) to fail.
> Somehow I ended up committing test_expect_success, which I think was a
> mistake, and I am asking for a sanity-check.
Yes, it should fail, so according to your filosophy, the test should be
reverted, i.e. ! git add "$d1 and that negated test should pass.
> Likewise for the other two tests. These "add outside" should fail, right?
>
> > +test_expect_failure 'add a file outside the work tree, nasty case 1' '(
> > + f="$(pwd)x" &&
> > + touch "$f" &&
> > + git add "$f"
> > +)'
> > +
> > +test_expect_failure 'add a file outside the work tree, nasty case 2' '(
> > + f="$(pwd|sed "s/.$//")x" &&
> > + touch "$f" &&
> > + git add "$f"
> > +)'
> > +
> > test_done
Yes.
-- robin
next prev parent reply other threads:[~2008-03-07 15:25 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-23 15:14 git-clean buglet Johannes Sixt
2008-01-23 15:24 ` Johannes Sixt
2008-01-23 15:29 ` Johannes Schindelin
2008-01-23 15:40 ` Johannes Sixt
2008-01-27 19:55 ` [PATCH] Fix off by one error in prep_exclude Shawn Bohrer
2008-01-27 20:44 ` Johannes Schindelin
2008-01-27 21:15 ` Shawn Bohrer
2008-01-27 22:34 ` Junio C Hamano
2008-01-28 0:34 ` Shawn Bohrer
2008-01-28 0:37 ` Shawn Bohrer
2008-01-28 11:59 ` Johannes Schindelin
2008-01-28 12:04 ` Junio C Hamano
2008-01-28 2:52 ` Junio C Hamano
2008-01-28 7:12 ` Johannes Sixt
2008-01-28 8:46 ` Junio C Hamano
2008-01-28 9:05 ` Johannes Sixt
2008-01-28 9:22 ` Junio C Hamano
2008-01-28 12:33 ` [RFH/PATCH] prefix_path(): disallow absolute paths Johannes Schindelin
2008-01-28 15:05 ` [PATCH] " Johannes Schindelin
2008-01-29 1:23 ` [RFH/PATCH] " Junio C Hamano
2008-01-29 2:03 ` Junio C Hamano
2008-01-29 2:03 ` Junio C Hamano
2008-01-29 7:02 ` Junio C Hamano
2008-01-29 8:29 ` [PATCH] setup: sanitize absolute and funny paths in get_pathspec() Junio C Hamano
2008-02-01 4:07 ` [PATCH] Make blame accept absolute paths Robin Rosenberg
2008-02-01 4:34 ` [PATCH] More test cases for sanitized path names Robin Rosenberg
2008-02-01 7:17 ` Junio C Hamano
2008-02-01 9:10 ` Robin Rosenberg
2008-02-01 10:22 ` Junio C Hamano
2008-02-01 10:51 ` Junio C Hamano
2008-02-01 11:10 ` Junio C Hamano
2008-02-01 14:17 ` Robin Rosenberg
2008-02-01 17:45 ` Junio C Hamano
2008-02-01 9:16 ` Karl Hasselström
2008-02-01 9:50 ` [PATCH for post 1.5.4] Sane use of test_expect_failure Junio C Hamano
2008-02-02 10:06 ` [PATCH] " Junio C Hamano
2008-03-07 8:23 ` [PATCH] More test cases for sanitized path names Junio C Hamano
2008-03-07 15:24 ` Robin Rosenberg [this message]
2008-01-29 2:37 ` [RFH/PATCH] prefix_path(): disallow absolute paths Johannes Schindelin
2008-01-29 2:45 ` Junio C Hamano
2008-01-29 2:59 ` Johannes Schindelin
2008-01-29 7:20 ` Johannes Sixt
2008-01-29 7:28 ` Junio C Hamano
2008-01-29 7:43 ` Johannes Sixt
2008-01-29 8:31 ` Junio C Hamano
2008-01-29 21:53 ` しらいしななこ
2008-01-30 0:43 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200803071624.35369.robin.rosenberg@dewire.com \
--to=robin.rosenberg@dewire$(echo .)com \
--cc=Johannes.Schindelin@gmx$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=j.sixt@viscovery$(echo .)net \
--cc=robin.rosenberg.lists@dewire$(echo .)com \
--cc=shawn.bohrer@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox