public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: "Frank Ch. Eigler" <fche@redhat•com>
To: git@vger•kernel.org
Subject: reducing prune sync()s
Date: Thu, 29 May 2008 16:57:43 -0400	[thread overview]
Message-ID: <20080529205743.GC17123@redhat.com> (raw)

Hi -

In at least builtin-prune-packed.c, builtin-prune.c, and
guilt-repack.sh, there is an unconditional sync call.  On a machine
with lots of dirty disk data, writing it to some slow device, this
sync can take a long time.

Would there be interest in making this sync disableable with
git-config?  Or perhaps having the blanket sync be replaced a
list of fsync()s for only the relevant git repository files?

- FChE

             reply	other threads:[~2008-05-29 20:59 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-29 20:57 Frank Ch. Eigler [this message]
2008-05-30  0:27 ` reducing prune sync()s Linus Torvalds
2008-05-30  0:32   ` Linus Torvalds
2008-05-30  1:50     ` Frank Ch. Eigler
2008-05-30 20:07     ` Florian Weimer
2008-05-30  1:51   ` David Dillow
2008-05-30  2:17     ` Linus Torvalds
2008-05-30  2:30       ` Linus Torvalds
2008-05-30 15:25   ` Frank Ch. Eigler
2008-05-30 15:57     ` Linus Torvalds
2008-05-30 16:08       ` [PATCH 1/2] Make pack creation always fsync() the result Linus Torvalds
2008-05-30 16:11         ` [PATCH 2/2] Remove now unnecessary 'sync()' calls Linus Torvalds
2008-05-30 20:27         ` [PATCH 1/2] Make pack creation always fsync() the result Nicolas Pitre
2008-05-31 14:19         ` Frank Ch. Eigler
2008-06-02 22:23           ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080529205743.GC17123@redhat.com \
    --to=fche@redhat$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox