From: Ingo Molnar <mingo@elte•hu>
To: Junio C Hamano <gitster@pobox•com>
Cc: "Shawn O. Pearce" <spearce@spearce•org>,
git@vger•kernel.org, Petr Baudis <pasky@suse•cz>
Subject: Re: [PATCH] bash completion: Improve responsiveness of git-log completion
Date: Mon, 14 Jul 2008 00:12:02 +0200 [thread overview]
Message-ID: <20080713221202.GA4204@elte.hu> (raw)
In-Reply-To: <7vy745piqy.fsf@gitster.siamese.dyndns.org>
* Junio C Hamano <gitster@pobox•com> wrote:
> "Shawn O. Pearce" <spearce@spearce•org> writes:
>
> > Junio noticed the bash completion has been taking a long time lately....
>
> The credit actually goes to Ingo.
>
> > Petr Baudis tracked it down to 72e5e989b ("bash: Add space after
> > unique command name is completed."). Tracing the code showed
> > we spent significant time inside of this loop within __gitcomp,
> > due to the string copying overhead....
> > ...
> > Does this make things better? Or worse? I'm not seeing a huge
> > difference on my own system. Maybe its too fast these days...
>
> Ingo, I understand you have stopped using the completion long time ago
> due to this latency issue. Together with d773c63 (bash: offer only
> paths after '--', 2008-07-08) that already is in 'maint' and 'master',
> this hopefully would make the completion usable for you again?
yeah. I've checked out the latest version and applied Shawn's patch and
added the patched contrib/completion/git-completion.bash back to my
.bashrc and i'm not seeing the latencies anymore.
Thanks! Please consider this fixed - will follow up if there's any
problem left.
Ingo
prev parent reply other threads:[~2008-07-13 22:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-13 2:37 [PATCH] bash completion: Improve responsiveness of git-log completion Shawn O. Pearce
2008-07-13 4:02 ` Petr Baudis
2008-07-13 13:55 ` Johannes Schindelin
2008-07-13 21:38 ` Junio C Hamano
2008-07-13 22:12 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080713221202.GA4204@elte.hu \
--to=mingo@elte$(echo .)hu \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=pasky@suse$(echo .)cz \
--cc=spearce@spearce$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox