From: Don Zickus <dzickus@redhat•com>
To: Junio C Hamano <gitster@pobox•com>
Cc: "Lukas Sandström" <lukass@etek•chalmers.se>,
"Git Mailing List" <git@vger•kernel.org>
Subject: Re: [PATCH] git-mailinfo: Fix getting the subject from the body
Date: Mon, 14 Jul 2008 23:13:56 -0400 [thread overview]
Message-ID: <20080715031356.GQ16127@redhat.com> (raw)
In-Reply-To: <7v3amfxx3a.fsf@gitster.siamese.dyndns.org>
On Sat, Jul 12, 2008 at 02:36:57AM -0700, Junio C Hamano wrote:
> Another thing I noticed and found puzzling is the handling of ">From "
> line that is shown in the context below. check_header() is supposed to
> return true when it handled header (i.e. not part of the commit message)
> and return false when line is not part of the header. As ">From " is part
> of the commit log message, shouldn't it return zero?
>
> Don, this part was what you introduced. Has this codepath ever been
> exercised in the real life?
Heh. Most emails I deal with usually wind up causing the code to stop
looking for header info (still_looking=0). So I never ran into that
scenario. And I never really tried to rely on inbody stuff.
I thought I was mimicing the original code, guess not.
Now that I think about it, I did run into a situation last year where
git-mailinfo parsed the '>From' as an inbody header instead of a commit
msg. I just put a stupid hack in my scripts to work around, thinking it
was my scripts.
Anyway if it returns zero, wouldn't it be better to just remove the check
to begin with? I kinda forgot why it is there in the first place (my
changes just copied it from somewhere else).
Cheers,
Don
prev parent reply other threads:[~2008-07-15 3:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-10 21:41 [PATCH] git-mailinfo: Fix getting the subject from the body Lukas Sandström
[not found] ` <7vod55o0tx.fsf@gitster.siamese.dyndns.org>
2008-07-10 22:37 ` Lukas Sandström
2008-07-10 23:25 ` Junio C Hamano
2008-07-10 23:41 ` [PATCH] Add some useful functions for strbuf manipulation Lukas Sandström
2008-07-10 23:43 ` [PATCH/RFC] git-mailinfo: use strbuf's instead of fixed buffers Lukas Sandström
2008-07-12 6:10 ` Junio C Hamano
2008-07-13 18:17 ` ! " Lukas Sandström
2008-07-13 18:28 ` [PATCH] Make some strbuf_*() struct strbuf arguments const Lukas Sandström
2008-07-13 18:29 ` [PATCH] Add some useful functions for strbuf manipulation Lukas Sandström
2008-07-13 18:30 ` [PATCH] git-mailinfo: use strbuf's instead of fixed buffers Lukas Sandström
2008-07-13 21:37 ` Junio C Hamano
2008-07-12 9:36 ` [PATCH] git-mailinfo: Fix getting the subject from the body Junio C Hamano
2008-07-12 21:45 ` Lukas Sandström
2008-07-15 3:13 ` Don Zickus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080715031356.GQ16127@redhat.com \
--to=dzickus@redhat$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=lukass@etek$(echo .)chalmers.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox