From: Petr Baudis <pasky@suse•cz>
To: Johannes Schindelin <Johannes.Schindelin@gmx•de>
Cc: gitster@pobox•com, git@vger•kernel.org
Subject: Re: [PATCH] git-filter-branch.sh: Allow running in bare repositories
Date: Thu, 24 Jul 2008 00:06:57 +0200 [thread overview]
Message-ID: <20080723220657.GA10151@machine.or.cz> (raw)
In-Reply-To: <alpine.DEB.1.00.0807232257500.8986@racer>
Hi,
On Wed, Jul 23, 2008 at 10:59:03PM +0100, Johannes Schindelin wrote:
> On Wed, 23 Jul 2008, Petr Baudis wrote:
>
> > Commit 46eb449c restricted git-filter-branch to non-bare repositories
> > unnecessarily; git-filter-branch can work on bare repositories just
> > fine.
> >
> > Cc: Johannes Schindelin <Johannes.Schindelin@gmx•de>
>
> Funny, I did not get Cc:ed.
sorry, I have to copy the Cc around manually with StGIT. :/
> > -git diff-files --quiet &&
> > - git diff-index --cached --quiet HEAD -- ||
> > - die "Cannot rewrite branch(es) with a dirty working directory."
> > +if [ "$(is_bare_repository)" = false ]; then
> > + git diff-files --quiet &&
> > + git diff-index --cached --quiet HEAD --) ||
>
> ^
>
> I doubt this has ever passed the test suite, let alone run.
It did... provided that I didn't make after modifying the script.
> Besides, this extra-funny extra indent is quite brutal on my eyes.
I kept the original indentation.
Petr "Pasky" Baudis
next prev parent reply other threads:[~2008-07-23 22:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-22 22:37 [PATCH] git-filter-branch.sh: Allow running in bare repositories Petr Baudis
2008-07-22 23:27 ` Johannes Schindelin
2008-07-22 23:36 ` Petr Baudis
2008-07-23 0:09 ` Junio C Hamano
2008-07-23 21:55 ` Petr Baudis
2008-07-23 21:59 ` Johannes Schindelin
2008-07-23 22:06 ` Petr Baudis [this message]
2008-07-23 22:15 ` [PATCHv3] " Petr Baudis
2008-07-23 22:29 ` Junio C Hamano
2008-07-23 22:29 ` [PATCH] " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080723220657.GA10151@machine.or.cz \
--to=pasky@suse$(echo .)cz \
--cc=Johannes.Schindelin@gmx$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox