From: Petr Baudis <pasky@suse•cz>
To: Junio C Hamano <gitster@pobox•com>, ams@toroid•org
Cc: git@vger•kernel.org
Subject: Re: [PATCH] Git.pm: Fix internal git_command_bidi_pipe() users
Date: Mon, 4 Aug 2008 10:21:17 +0200 [thread overview]
Message-ID: <20080804082117.GI10151@machine.or.cz> (raw)
In-Reply-To: <7vtze12oij.fsf@gitster.siamese.dyndns.org>
On Mon, Aug 04, 2008 at 01:05:56AM -0700, Junio C Hamano wrote:
> Petr Baudis <pasky@suse•cz> writes:
>
> > The hash_and_insert_object() and cat_blob() helpers were using
> > an incorrect slice-from-ref Perl syntax. This patch fixes that up
> > in the _close_*() helpers and make the _open_*() helpers use the
> > same syntax for consistnecy.
> >
> > Signed-off-by: Petr Baudis <pasky@suse•cz>
> > ---
> >
> > Wow, the command_bidi_pipe API really is dirty. Of course, it is
> > my fault as anyone's since I didn't get around to review the patches
> > introducing it.
>
> Sorry, delete is still broken with your patch, isn't it?
Oh, right - I forgot that one and it didn't occur to me to test this
part.
> The earlier patch from Abhijit Menon-Sen does this properly for
> close_hash_and_insert and close_cat_blob, which I've queued already.
Abhijit, can you please tag your Git.pm patches so that I actually have
a chance to see and review it?
Thanks,
Petr "Pasky" Baudis
next prev parent reply other threads:[~2008-08-04 8:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-04 4:49 [git/perl] unusual syntax? Ray Chuan
2008-08-04 5:02 ` [PATCH] Fix hash slice syntax error Abhijit Menon-Sen
2008-08-04 7:56 ` [PATCH] Git.pm: Fix internal git_command_bidi_pipe() users Petr Baudis
2008-08-04 8:05 ` Junio C Hamano
2008-08-04 8:21 ` Petr Baudis [this message]
2008-08-04 8:37 ` Junio C Hamano
2008-08-04 11:38 ` [PATCH] Git.pm: localise $? in command_close_bidi_pipe() Abhijit Menon-Sen
2008-08-05 6:12 ` Junio C Hamano
2008-08-04 15:01 ` [git/perl] unusual syntax? David Christensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080804082117.GI10151@machine.or.cz \
--to=pasky@suse$(echo .)cz \
--cc=ams@toroid$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox